Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Side by Side Diff: src/ic/mips/ic-mips.cc

Issue 2343813002: [ic] Move KeyedStoreIC::GenerateSlow() to ic-XXX.cc to avoid code duplication. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/mips/handler-compiler-mips.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 705 matching lines...) Expand 10 before | Expand all | Expand 10 after
716 StoreWithVectorDescriptor::VectorRegister()); 716 StoreWithVectorDescriptor::VectorRegister());
717 } 717 }
718 718
719 719
720 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) { 720 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) {
721 StoreIC_PushArgs(masm); 721 StoreIC_PushArgs(masm);
722 722
723 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss); 723 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss);
724 } 724 }
725 725
726 void KeyedStoreIC::GenerateSlow(MacroAssembler* masm) {
727 StoreIC_PushArgs(masm);
728
729 // The slow case calls into the runtime to complete the store without causing
730 // an IC miss that would otherwise cause a transition to the generic stub.
731 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow);
732 }
733
726 void StoreIC::GenerateMiss(MacroAssembler* masm) { 734 void StoreIC::GenerateMiss(MacroAssembler* masm) {
727 StoreIC_PushArgs(masm); 735 StoreIC_PushArgs(masm);
728 736
729 // Perform tail call to the entry. 737 // Perform tail call to the entry.
730 __ TailCallRuntime(Runtime::kStoreIC_Miss); 738 __ TailCallRuntime(Runtime::kStoreIC_Miss);
731 } 739 }
732 740
733 741
734 void StoreIC::GenerateNormal(MacroAssembler* masm) { 742 void StoreIC::GenerateNormal(MacroAssembler* masm) {
735 Label miss; 743 Label miss;
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
879 break; 887 break;
880 default: 888 default:
881 UNIMPLEMENTED(); 889 UNIMPLEMENTED();
882 } 890 }
883 patcher.ChangeBranchCondition(branch_instr, opcode); 891 patcher.ChangeBranchCondition(branch_instr, opcode);
884 } 892 }
885 } // namespace internal 893 } // namespace internal
886 } // namespace v8 894 } // namespace v8
887 895
888 #endif // V8_TARGET_ARCH_MIPS 896 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ic/mips/handler-compiler-mips.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698