[d8] Fix the shared-library build

[d8] Fix the shared-library build

This commit ensures that the d8 shared library build uses the same logic as
the standard static build by exporting relevant functions and classes.

BUG=chromium:646337
Committed: https://crrev.com/2c10ca8086a4d595ecf9aa843d2031b068470d65
Committed: https://crrev.com/4f5695229e49a7615bf7b03d26209314ffa48985
Cr-Original-Commit-Position: refs/heads/master@{#39503}
Cr-Commit-Position: refs/heads/master@{#39547}

[jgruber, 2016-09-14 11:16:35]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 11:16:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 11:20:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 11:20:55]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24031)

[jgruber, 2016-09-14 11:29:53]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 11:30:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-09-14 11:48:50]

Description was changed from

==========
[d8] Fix the shared-library build

This commit ensures that the shared-library build of d8 uses the same logic as
the standard static build by exporting relevant functions and classes.

BUG=chromium:646337
==========

to

==========
[d8] Fix the shared-library build

This commit ensures that the d8 shared library build uses the same logic as
the standard static build by exporting relevant functions and classes.

BUG=chromium:646337
==========

[commit-bot: I haz the power, 2016-09-14 11:57:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 11:57:04]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[jgruber, 2016-09-14 13:59:50]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 13:59:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 14:15:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 14:15:17]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jgruber, 2016-09-14 14:35:42]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 14:35:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 14:47:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 14:47:39]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jgruber, 2016-09-14 14:57:18]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 14:57:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 15:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 15:14:06]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jgruber, 2016-09-14 15:33:31]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 15:33:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 15:43:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 15:43:50]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jgruber, 2016-09-15 07:47:27]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 07:47:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 07:56:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 07:56:44]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jgruber, 2016-09-15 08:11:00]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 08:11:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 08:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 08:26:46]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jgruber, 2016-09-15 09:16:44]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 09:16:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 09:36:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 09:36:44]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jgruber, 2016-09-15 09:44:34]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 09:44:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-09-15 10:12:12]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 10:12:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 10:25:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 10:25:47]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jgruber, 2016-09-15 10:43:18]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 10:43:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 11:13:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 11:13:04]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-09-15 11:40:14]

jgruber@chromium.org changed reviewers:
+ jochen@chromium.org, machenbach@chromium.org

[jochen (gone - plz use gerrit), 2016-09-15 11:41:38]

so good

lgtm

[Michael Achenbach, 2016-09-19 06:59:40]

lgtm - will this (or more of this) also enable cctest and unittests to use
shared libraries?

[jochen (gone - plz use gerrit), 2016-09-19 07:01:43]

On 2016/09/19 at 06:59:40, machenbach wrote:
> lgtm - will this (or more of this) also enable cctest and unittests to use
shared libraries?

I'd expect that getting cctests to work would require some additional work.
Given that we have that linker hack for it, I'm not sure it's worth the effort,
however, we can certainly try. Maybe unittests just works with this cl landed?

[jgruber, 2016-09-19 07:23:03]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-09-19 07:23:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 07:27:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 07:27:18]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24322)

[jgruber, 2016-09-19 07:38:35]

jgruber@chromium.org changed reviewers:
+ bmeurer@chromium.org, titzer@chromium.org, vogelheim@chromium.org

[jgruber, 2016-09-19 07:38:36]

+vogelheim for snapshot/
+bmeurer for interpreter/
+titzer for wasm/

[Michael Achenbach, 2016-09-19 09:10:47]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 09:10:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 09:13:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 09:13:06]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-09-19 10:35:52]

On 2016/09/19 07:38:36, jgruber wrote:
> +vogelheim for snapshot/
> +bmeurer for interpreter/
> +titzer for wasm/

lgtm

[vogelheim, 2016-09-19 11:42:47]

lgtm for src/snapshot/...

[Benedikt Meurer, 2016-09-19 12:43:10]

lgtm

[jgruber, 2016-09-19 12:44:43]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-09-19 12:44:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 12:47:07]

Description was changed from

==========
[d8] Fix the shared-library build

This commit ensures that the d8 shared library build uses the same logic as
the standard static build by exporting relevant functions and classes.

BUG=chromium:646337
==========

to

==========
[d8] Fix the shared-library build

This commit ensures that the d8 shared library build uses the same logic as
the standard static build by exporting relevant functions and classes.

BUG=chromium:646337
==========

[commit-bot: I haz the power, 2016-09-19 12:47:09]

Committed patchset #12 (id:20002)

[commit-bot: I haz the power, 2016-09-19 12:47:28]

Description was changed from

==========
[d8] Fix the shared-library build

This commit ensures that the d8 shared library build uses the same logic as
the standard static build by exporting relevant functions and classes.

BUG=chromium:646337
==========

to

==========
[d8] Fix the shared-library build

This commit ensures that the d8 shared library build uses the same logic as
the standard static build by exporting relevant functions and classes.

BUG=chromium:646337

Committed: https://crrev.com/2c10ca8086a4d595ecf9aa843d2031b068470d65
Cr-Commit-Position: refs/heads/master@{#39503}
==========

[commit-bot: I haz the power, 2016-09-19 12:47:30]

Patchset 12 (id:??) landed as
https://crrev.com/2c10ca8086a4d595ecf9aa843d2031b068470d65
Cr-Commit-Position: refs/heads/master@{#39503}

[Michael Achenbach, 2016-09-19 21:11:59]

meh: double bug.

Bug one, this potentially breaks chromium android dbg and blocks the roll, see:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...
https://codereview.chromium.org/2348083004/

Bug two, I added exactly this trybot to the CL (gut feeling) and the lazy
bastard didn't bother compiling and went green, probably an analyze bug:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...

[Michael Achenbach, 2016-09-20 07:12:24]

A revert of this CL (patchset #12 id:20002) has been created in
https://codereview.chromium.org/2356703003/ by machenbach@chromium.org.

The reason for reverting is: Unblocking roll.

[jgruber, 2016-09-20 07:18:28]

Description was changed from

==========
[d8] Fix the shared-library build

This commit ensures that the d8 shared library build uses the same logic as
the standard static build by exporting relevant functions and classes.

BUG=chromium:646337

Committed: https://crrev.com/2c10ca8086a4d595ecf9aa843d2031b068470d65
Cr-Commit-Position: refs/heads/master@{#39503}
==========

to

==========
[d8] Fix the shared-library build

This commit ensures that the d8 shared library build uses the same logic as
the standard static build by exporting relevant functions and classes.

BUG=chromium:646337

Committed: https://crrev.com/2c10ca8086a4d595ecf9aa843d2031b068470d65
Cr-Commit-Position: refs/heads/master@{#39503}
==========

[jgruber, 2016-09-20 07:36:09]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 07:36:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 07:46:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 07:46:05]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)

[jgruber, 2016-09-20 07:54:42]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 07:54:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 08:02:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 08:02:17]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)

[jgruber, 2016-09-20 11:31:37]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 11:31:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 12:01:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 12:01:38]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-09-20 12:04:08]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-09-20 12:04:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, titzer@chromium.org, jochen@chromium.org,
vogelheim@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2342563002/#ps270001
(title: "Mark as extern in .cc")

[commit-bot: I haz the power, 2016-09-20 12:04:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 12:06:41]

Description was changed from

==========
[d8] Fix the shared-library build

This commit ensures that the d8 shared library build uses the same logic as
the standard static build by exporting relevant functions and classes.

BUG=chromium:646337

Committed: https://crrev.com/2c10ca8086a4d595ecf9aa843d2031b068470d65
Cr-Commit-Position: refs/heads/master@{#39503}
==========

to

==========
[d8] Fix the shared-library build

This commit ensures that the d8 shared library build uses the same logic as
the standard static build by exporting relevant functions and classes.

BUG=chromium:646337

Committed: https://crrev.com/2c10ca8086a4d595ecf9aa843d2031b068470d65
Cr-Commit-Position: refs/heads/master@{#39503}
==========

[commit-bot: I haz the power, 2016-09-20 12:06:43]

Committed patchset #15 (id:270001)

[commit-bot: I haz the power, 2016-09-20 12:07:04]

Description was changed from

==========
[d8] Fix the shared-library build

This commit ensures that the d8 shared library build uses the same logic as
the standard static build by exporting relevant functions and classes.

BUG=chromium:646337

Committed: https://crrev.com/2c10ca8086a4d595ecf9aa843d2031b068470d65
Cr-Commit-Position: refs/heads/master@{#39503}
==========

to

==========
[d8] Fix the shared-library build

This commit ensures that the d8 shared library build uses the same logic as
the standard static build by exporting relevant functions and classes.

BUG=chromium:646337

Committed: https://crrev.com/2c10ca8086a4d595ecf9aa843d2031b068470d65
Committed: https://crrev.com/4f5695229e49a7615bf7b03d26209314ffa48985
Cr-Original-Commit-Position: refs/heads/master@{#39503}
Cr-Commit-Position: refs/heads/master@{#39547}
==========

[commit-bot: I haz the power, 2016-09-20 12:07:06]

Patchset 15 (id:??) landed as
https://crrev.com/4f5695229e49a7615bf7b03d26209314ffa48985
Cr-Commit-Position: refs/heads/master@{#39547}