Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: src/v8.gyp

Issue 2342563002: [d8] Fix the shared-library build (Closed)
Patch Set: Mark as extern in .cc Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/utils.cc ('k') | src/wasm/wasm-js.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/v8.gyp
diff --git a/src/v8.gyp b/src/v8.gyp
index 7b2fb2584695f99c6d8367f5035e1dc1c621e0db..2a3028b24aa37f47222d0ef35b990de2250f9aee 100644
--- a/src/v8.gyp
+++ b/src/v8.gyp
@@ -61,12 +61,10 @@
'..',
],
'defines': [
- 'V8_SHARED',
'BUILDING_V8_SHARED',
],
'direct_dependent_settings': {
'defines': [
- 'V8_SHARED',
'USING_V8_SHARED',
],
},
@@ -164,12 +162,10 @@
}],
['component=="shared_library"', {
'defines': [
- 'V8_SHARED',
'BUILDING_V8_SHARED',
],
'direct_dependent_settings': {
'defines': [
- 'V8_SHARED',
'USING_V8_SHARED',
],
},
@@ -259,7 +255,6 @@
['component=="shared_library"', {
'defines': [
'BUILDING_V8_SHARED',
- 'V8_SHARED',
],
}],
]
@@ -286,12 +281,10 @@
}],
['component=="shared_library"', {
'defines': [
- 'V8_SHARED',
'BUILDING_V8_SHARED',
],
'direct_dependent_settings': {
'defines': [
- 'V8_SHARED',
'USING_V8_SHARED',
],
},
@@ -1713,7 +1706,6 @@
['component=="shared_library"', {
'defines': [
'BUILDING_V8_SHARED',
- 'V8_SHARED',
],
}],
['v8_postmortem_support=="true"', {
« no previous file with comments | « src/utils.cc ('k') | src/wasm/wasm-js.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698