Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/inspector/BUILD.gn

Issue 2342563002: [d8] Fix the shared-library build (Closed)
Patch Set: Mark as extern in .cc Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/spaces.h ('k') | src/interpreter/interpreter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/BUILD.gn
diff --git a/src/inspector/BUILD.gn b/src/inspector/BUILD.gn
index 31ed0cfb4cacf8ebe3c749219d5b75b7927d15c3..45db1e5db2bac0f170606beb70af1f343e005aab 100644
--- a/src/inspector/BUILD.gn
+++ b/src/inspector/BUILD.gn
@@ -106,10 +106,7 @@ config("inspector_config") {
]
}
if (is_component_build) {
- defines = [
- "V8_SHARED",
- "BUILDING_V8_SHARED",
- ]
+ defines = [ "BUILDING_V8_SHARED" ]
}
}
« no previous file with comments | « src/heap/spaces.h ('k') | src/interpreter/interpreter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698