Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: src/factory.h

Issue 2342563002: [d8] Fix the shared-library build (Closed)
Patch Set: Mark as extern in .cc Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/d8.gyp ('k') | src/flag-definitions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/factory.h
diff --git a/src/factory.h b/src/factory.h
index 78ee647f9743e77078bb8213fa1d13f1cf51e917..94ae55850a3a243bd7c6bbb63ebc510d5f7c5ebb 100644
--- a/src/factory.h
+++ b/src/factory.h
@@ -28,9 +28,8 @@ class Factory final {
byte kind);
// Allocates a fixed array initialized with undefined values.
- Handle<FixedArray> NewFixedArray(
- int size,
- PretenureFlag pretenure = NOT_TENURED);
+ V8_EXPORT_PRIVATE Handle<FixedArray> NewFixedArray(
+ int size, PretenureFlag pretenure = NOT_TENURED);
// Allocate a new fixed array with non-existing entries (the hole).
Handle<FixedArray> NewFixedArrayWithHoles(
@@ -165,9 +164,8 @@ class Factory final {
// UTF8 strings are pretenured when used for regexp literal patterns and
// flags in the parser.
- MUST_USE_RESULT MaybeHandle<String> NewStringFromUtf8(
- Vector<const char> str,
- PretenureFlag pretenure = NOT_TENURED);
+ MUST_USE_RESULT V8_EXPORT_PRIVATE MaybeHandle<String> NewStringFromUtf8(
+ Vector<const char> str, PretenureFlag pretenure = NOT_TENURED);
MUST_USE_RESULT MaybeHandle<String> NewStringFromTwoByte(
Vector<const uc16> str,
@@ -457,11 +455,11 @@ class Factory final {
}
// Create a JSArray with the given elements.
- Handle<JSArray> NewJSArrayWithElements(Handle<FixedArrayBase> elements,
- ElementsKind elements_kind, int length,
- PretenureFlag pretenure = NOT_TENURED);
+ V8_EXPORT_PRIVATE Handle<JSArray> NewJSArrayWithElements(
+ Handle<FixedArrayBase> elements, ElementsKind elements_kind, int length,
+ PretenureFlag pretenure = NOT_TENURED);
- Handle<JSArray> NewJSArrayWithElements(
+ V8_EXPORT_PRIVATE Handle<JSArray> NewJSArrayWithElements(
Handle<FixedArrayBase> elements,
ElementsKind elements_kind = TERMINAL_FAST_ELEMENTS_KIND,
PretenureFlag pretenure = NOT_TENURED) {
« no previous file with comments | « src/d8.gyp ('k') | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698