[d8] Fix the shared-library build

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
 import("//build/config/dcheck_always_on.gni")
 import("//build/config/mips.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 
@@ skipping 97 matching lines @@
 
 ###############################################################################
 # Configurations
 #
 config("internal_config") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   include_dirs = [ "." ]
 
   if (is_component_build) {
-    defines = [
-      "V8_SHARED",
-      "BUILDING_V8_SHARED",
-    ]
+    defines = [ "BUILDING_V8_SHARED" ]
   }
 }
 
 config("internal_config_base") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   include_dirs = [ "." ]
 }
 
 # This config should be applied to code using the libplatform.
 config("libplatform_config") {
   include_dirs = [ "include" ]
 }
 
 # This config should be applied to code using the libsampler.
 config("libsampler_config") {
   include_dirs = [ "include" ]
 }
 
 # This config should only be applied to code using V8 and not any V8 code
 # itself.
 config("external_config") {
   if (is_component_build) {
-    defines = [
-      "V8_SHARED",
-      "USING_V8_SHARED",
-    ]
+    defines = [ "USING_V8_SHARED" ]
   }
   include_dirs = [ "include" ]
   if (v8_enable_inspector_override) {
     include_dirs += [ "$target_gen_dir/include" ]
   }
   libs = []
   if (is_android && current_toolchain != host_toolchain) {
     libs += [ "log" ]
   }
 }
@@ skipping 2223 matching lines @@
     public_deps = [
       ":v8_base",
       ":v8_maybe_snapshot",
     ]
     public_configs = [ ":external_config" ]
   }
 }
 
 v8_executable("d8") {
   sources = [
+    "$target_gen_dir/d8-js.cc",
     "src/d8.cc",
     "src/d8.h",
   ]
 
   configs = [
     # Note: don't use :internal_config here because this target will get
     # the :external_config applied to it by virtue of depending on :v8, and
     # you can't have both applied to the same target.
     ":internal_config_base",
   ]
 
   deps = [
     ":d8_js2c",
     ":v8",
     ":v8_libplatform",
     "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
   ]
 
   # TODO(jochen): Add support for vtunejit.
 
   if (is_posix) {
     sources += [ "src/d8-posix.cc" ]
   } else if (is_win) {
     sources += [ "src/d8-windows.cc" ]
   }
 
-  if (!is_component_build) {
-    sources += [ "$target_gen_dir/d8-js.cc" ]
-  }
   if (v8_enable_i18n_support) {
     deps += [ "//third_party/icu" ]
   }
 }
 
 v8_isolate_run("d8") {
   deps = [
     ":d8",
   ]
 
@@ skipping 350 matching lines @@
     ":fuzzer_support",
     ":lib_wasm_section_fuzzer",
     ":wasm_module_runner",
   ]
 
   configs = [ ":internal_config" ]
 }
 
 v8_fuzzer("wasm_data_section_fuzzer") {
 }