Add error details to TBSCertificate parsing function and tests.

Add error details to TBSCertificate parsing function and tests.

BUG=634443
Committed: https://crrev.com/929a0aa40999c33cd09e04cbdfc77fd71c5b9cc3
Cr-Commit-Position: refs/heads/master@{#419363}

[eroman, 2016-09-15 00:46:43]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[eroman, 2016-09-15 00:46:52]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[commit-bot: I haz the power, 2016-09-15 00:47:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 01:13:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 01:13:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eroman, 2016-09-16 18:30:15]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 18:31:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 18:58:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 18:58:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mattm, 2016-09-16 21:41:48]

lgtm (with one question)

https://codereview.chromium.org/2341943002/diff/20001/net/cert/internal/parse...
File net/cert/internal/parse_certificate.cc (right):

https://codereview.chromium.org/2341943002/diff/20001/net/cert/internal/parse...
net/cert/internal/parse_certificate.cc:34: "Unconsumed data inside
TBSCertificate");
should tbs be lowercase?

[eroman, 2016-09-16 22:07:18]

https://codereview.chromium.org/2341943002/diff/20001/net/cert/internal/parse...
File net/cert/internal/parse_certificate.cc (right):

https://codereview.chromium.org/2341943002/diff/20001/net/cert/internal/parse...
net/cert/internal/parse_certificate.cc:34: "Unconsumed data inside
TBSCertificate");
On 2016/09/16 21:41:48, mattm wrote:
> should tbs be lowercase?

I intentionally upper-cased it to refer to the type, rather than the field name
in Certificate.

Because ParseTbsCertificate can be called independently, and hence technically
may not refer to the tbsCertificate field.

[mattm, 2016-09-16 22:16:45]

https://codereview.chromium.org/2341943002/diff/20001/net/cert/internal/parse...
File net/cert/internal/parse_certificate.cc (right):

https://codereview.chromium.org/2341943002/diff/20001/net/cert/internal/parse...
net/cert/internal/parse_certificate.cc:34: "Unconsumed data inside
TBSCertificate");
On 2016/09/16 22:07:18, eroman wrote:
> On 2016/09/16 21:41:48, mattm wrote:
> > should tbs be lowercase?
> 
> I intentionally upper-cased it to refer to the type, rather than the field
name
> in Certificate.
> 
> Because ParseTbsCertificate can be called independently, and hence technically
> may not refer to the tbsCertificate field.

ah, sounds good.

[eroman, 2016-09-16 22:27:40]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 22:28:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 22:57:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 22:57:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eroman, 2016-09-17 00:51:08]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 00:51:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-17 00:54:12]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 00:54:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-17 01:08:10]

The CQ bit was unchecked by eroman@chromium.org

[eroman, 2016-09-17 01:08:15]

The CQ bit was checked by eroman@chromium.org

[eroman, 2016-09-17 01:08:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2341943002/#ps80001
(title: "fix fuzzer compile")

[commit-bot: I haz the power, 2016-09-17 01:08:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 02:03:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-17 02:05:08]

Description was changed from

==========
Add error details to TBSCertificate parsing function and tests.

BUG=634443
==========

to

==========
Add error details to TBSCertificate parsing function and tests.

BUG=634443

Committed: https://crrev.com/929a0aa40999c33cd09e04cbdfc77fd71c5b9cc3
Cr-Commit-Position: refs/heads/master@{#419363}
==========

[commit-bot: I haz the power, 2016-09-17 02:05:09]

Patchset 5 (id:??) landed as
https://crrev.com/929a0aa40999c33cd09e04cbdfc77fd71c5b9cc3
Cr-Commit-Position: refs/heads/master@{#419363}