net/cert/internal/parse_certificate_fuzzer.cc - Issue 2341943002: Add error details to TBSCertificate parsing function and tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/parse_certificate_fuzzer.cc

Issue 2341943002: Add error details to TBSCertificate parsing function and tests. (Closed)

Patch Set: fix fuzzer compile Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/internal/parse_certificate_fuzzer.cc

diff --git a/net/cert/internal/parse_certificate_fuzzer.cc b/net/cert/internal/parse_certificate_fuzzer.cc

index 956bc3e69090756a06079db4ee832befb5c61ce2..ff97cfa4208562cd62ae04e55665bc0e8bacbf5f 100644

--- a/net/cert/internal/parse_certificate_fuzzer.cc

+++ b/net/cert/internal/parse_certificate_fuzzer.cc

@@ -41,7 +41,7 @@ void ParseCertificateForFuzzer(const der::Input& in) {

SignatureAlgorithm::CreateFromDer(signature_algorithm_tlv));

ParsedTbsCertificate tbs;

- if (!ParseTbsCertificate(tbs_certificate_tlv, {}, &tbs))

+ if (!ParseTbsCertificate(tbs_certificate_tlv, {}, &tbs, &errors))

return;

RDNSequence subject;