Add error details to TBSCertificate parsing function and tests.

net/cert/internal/parse_ocsp.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/sha1.h"
 #include "crypto/sha2.h"
+#include "net/cert/internal/cert_errors.h"
 #include "net/cert/internal/parse_ocsp.h"
 #include "net/der/encode_values.h"
 
 namespace net {
 
 OCSPCertID::OCSPCertID() {}
 OCSPCertID::~OCSPCertID() {}
 
 OCSPSingleResponse::OCSPSingleResponse() {}
 OCSPSingleResponse::~OCSPSingleResponse() {}
@@ skipping 474 matching lines @@
 
 }  // namespace
 
 bool GetOCSPCertStatus(const OCSPResponseData& response_data,
                        const der::Input& issuer_tbs_certificate_tlv,
                        const der::Input& cert_tbs_certificate_tlv,
                        OCSPCertStatus* out) {
   out->status = OCSPRevocationStatus::GOOD;
 
   ParsedTbsCertificate tbs_cert;
-  if (!ParseTbsCertificate(cert_tbs_certificate_tlv, {}, &tbs_cert))
+  // TODO(crbug.com/634443): Propagate the errors.
+  CertErrors errors;
+  if (!ParseTbsCertificate(cert_tbs_certificate_tlv, {}, &tbs_cert, &errors))
     return false;
   ParsedTbsCertificate issuer_tbs_cert;
-  if (!ParseTbsCertificate(issuer_tbs_certificate_tlv, {}, &issuer_tbs_cert))
+  if (!ParseTbsCertificate(issuer_tbs_certificate_tlv, {}, &issuer_tbs_cert,
+                           &errors))
     return false;
 
   bool found = false;
   for (const auto& response : response_data.responses) {
     OCSPSingleResponse single_response;
     if (!ParseOCSPSingleResponse(response, &single_response))
       return false;
     if (CheckCertID(single_response.cert_id_tlv, tbs_cert, issuer_tbs_cert,
                     tbs_cert.serial_number)) {
       OCSPCertStatus new_status = single_response.cert_status;
@@ skipping 31 matching lines @@
                                         &earliest_this_update)) {
     return false;
   }
   if (response.this_update < earliest_this_update)
     return false;  // Response is too old.
 
   return true;
 }
 
 }  // namespace net