Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2349093002: Change the interface for parsing SignatureAlgorithm to take a (Closed)

Created:
4 years, 3 months ago by eroman
Modified:
4 years, 3 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the interface for parsing SignatureAlgorithm to take a CertErrors parameter. BUG=634443 Committed: https://crrev.com/1a2122a428c38f5af5365e16ef3a50c27f3a37e1 Cr-Commit-Position: refs/heads/master@{#419546}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : add comment #

Total comments: 1

Patch Set 4 : update fuzzer #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -16 lines) Patch
M net/cert/internal/parse_certificate_fuzzer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/cert/internal/parse_ocsp.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M net/cert/internal/parsed_certificate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/cert/internal/signature_algorithm.h View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M net/cert/internal/signature_algorithm.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M net/cert/internal/signature_algorithm_unittest.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M net/cert/internal/verify_certificate_chain.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/internal/verify_signed_data_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M net/cert/x509_util_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (15 generated)
eroman
https://codereview.chromium.org/2349093002/diff/40001/net/cert/internal/signature_algorithm.h File net/cert/internal/signature_algorithm.h (right): https://codereview.chromium.org/2349093002/diff/40001/net/cert/internal/signature_algorithm.h#newcode94 net/cert/internal/signature_algorithm.h:94: static std::unique_ptr<SignatureAlgorithm> Create( I dropped the "FromDer" from name ...
4 years, 3 months ago (2016-09-17 01:18:19 UTC) #6
mattm
lgtm
4 years, 3 months ago (2016-09-19 19:47:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349093002/60001
4 years, 3 months ago (2016-09-19 19:51:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349093002/80001
4 years, 3 months ago (2016-09-19 20:07:01 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-19 21:07:24 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:10:53 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1a2122a428c38f5af5365e16ef3a50c27f3a37e1
Cr-Commit-Position: refs/heads/master@{#419546}

Powered by Google App Engine
This is Rietveld 408576698