net/cert/x509_util.cc - Issue 2341943002: Add error details to TBSCertificate parsing function and tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_util.cc

Issue 2341943002: Add error details to TBSCertificate parsing function and tests. (Closed)

Patch Set: fix fuzzer compile Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/x509_util.cc

diff --git a/net/cert/x509_util.cc b/net/cert/x509_util.cc

index 490252c6a4de5f90aa312f09636ef6b40cc48149..9b0cf51466bc3b708c62f446172035d0d4a270b4 100644

--- a/net/cert/x509_util.cc

+++ b/net/cert/x509_util.cc

@@ -133,7 +133,7 @@ bool ParseCertificateSandboxed(const base::StringPiece& certificate,

ParsedTbsCertificate parsed_tbs_cert;

if (!ParseTbsCertificate(tbs_cert, ParseCertificateOptions(),

- &parsed_tbs_cert))

+ &parsed_tbs_cert, nullptr))

return false;

if (!GetCommonName(parsed_tbs_cert.subject_tlv, subject))