third_party/WebKit/Source/core/frame/LocalFrame.cpp - Issue 2341053002: Mark the createVisiblePosition overloads as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)

Patch Set: minor revision Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

index 88f438ad70a178aabf74ee5225fcd01dfa23a718..602b58a0855b4a8d8542475a60e638bc07c97c57 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

@@ -715,7 +715,7 @@ EphemeralRange LocalFrame::rangeForPoint(const IntPoint& framePoint)

if (positionWithAffinity.isNull())

return EphemeralRange();

- VisiblePosition position = createVisiblePosition(positionWithAffinity);

+ VisiblePosition position = createVisiblePositionDeprecated(positionWithAffinity);

VisiblePosition previous = previousPositionOf(position);

if (previous.isNotNull()) {

const EphemeralRange previousCharacterRange = makeRange(previous, position);