third_party/WebKit/Source/core/layout/HitTestResult.cpp - Issue 2341053002: Mark the createVisiblePosition overloads as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/HitTestResult.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)

Patch Set: minor revision Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/HitTestResult.cpp

diff --git a/third_party/WebKit/Source/core/layout/HitTestResult.cpp b/third_party/WebKit/Source/core/layout/HitTestResult.cpp

index 974045c3f60132bd8a04b96b3f256e97d8fff01f..eb65156f5e76c6e07b903c5a4669f59b51b3dd27 100644

--- a/third_party/WebKit/Source/core/layout/HitTestResult.cpp

+++ b/third_party/WebKit/Source/core/layout/HitTestResult.cpp

@@ -364,7 +364,7 @@ bool HitTestResult::isMisspelled() const

{

yosin_UTC9 2016/09/16 02:01:21 TODO: Since |HitTestResult::isMissspelled()| is ca

if (!innerNode() || !innerNode()->layoutObject())

return false;

- VisiblePosition pos = createVisiblePosition(innerNode()->layoutObject()->positionForPoint(localPoint()));

+ VisiblePosition pos = createVisiblePositionDeprecated(innerNode()->layoutObject()->positionForPoint(localPoint()));

if (pos.isNull())

return false;

return m_innerNode->document().markers().markersInRange(