third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp - Issue 2341053002: Mark the createVisiblePosition overloads as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)

Patch Set: minor revision Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

index 9a96b4a188a4ead9bf3468237d20040b6bae3411..c2f5ff0be1d66cb6bd43e3631d09e4429f683e36 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

@@ -400,7 +400,7 @@ VisiblePosition HTMLTextFormControlElement::visiblePositionForIndex(int index) c

return VisiblePosition();

CharacterIterator it(start, end);

it.advance(index - 1);

- return createVisiblePosition(it.endPosition(), TextAffinity::Upstream);

+ return createVisiblePositionDeprecated(it.endPosition(), TextAffinity::Upstream);

}

int HTMLTextFormControlElement::indexForVisiblePosition(const VisiblePosition& pos) const