third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp - Issue 2341053002: Mark the createVisiblePosition overloads as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)

Patch Set: minor revision Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp b/third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp

index 2d79b4472b99d4816114ee0c72a719946ed84b65..791989f7656c0824e9e53ce6c20cc39377ba22ed 100644

--- a/third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp

@@ -26,7 +26,7 @@ TEST_F(RelocatablePositionTest, position)

Position expectedPosition(boldface, PositionAnchorType::AfterAnchor);

Position trackedPosition = relocatablePosition.position();

EXPECT_TRUE(trackedPosition.anchorNode()->isConnected());

- EXPECT_EQ(createVisiblePosition(expectedPosition).deepEquivalent(), createVisiblePosition(trackedPosition).deepEquivalent());

+ EXPECT_EQ(createVisiblePositionDeprecated(expectedPosition).deepEquivalent(), createVisiblePositionDeprecated(trackedPosition).deepEquivalent());

yosin_UTC9 2016/09/16 02:01:21 Can we stop using |createVisbilePositionDeprecated

}

} // namespace blink