third_party/WebKit/Source/core/editing/spellcheck/TextCheckingParagraph.cpp - Issue 2341053002: Mark the createVisiblePosition overloads as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/TextCheckingParagraph.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)

Patch Set: minor revision Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp ('K') | « third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp ('k') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('j') | third_party/WebKit/Source/core/layout/HitTestResult.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/TextCheckingParagraph.cpp

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingParagraph.cpp b/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingParagraph.cpp

index e011035f8cb15deb26915b7fdd3e659f82ec6f2c..1f1d268d7763e1cbb0e486b763d6d9e495e3c865 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingParagraph.cpp

+++ b/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingParagraph.cpp

@@ -35,12 +35,12 @@ namespace blink {

static EphemeralRange expandToParagraphBoundary(const EphemeralRange& range)

{

- const VisiblePosition& start = createVisiblePosition(range.startPosition());

+ const VisiblePosition& start = createVisiblePositionDeprecated(range.startPosition());

DCHECK(start.isNotNull()) << range.startPosition();

const Position& paragraphStart = startOfParagraph(start).deepEquivalent();

DCHECK(paragraphStart.isNotNull()) << range.startPosition();

- const VisiblePosition& end = createVisiblePosition(range.endPosition());

+ const VisiblePosition& end = createVisiblePositionDeprecated(range.endPosition());

DCHECK(end.isNotNull()) << range.endPosition();

const Position& paragraphEnd = endOfParagraph(end).deepEquivalent();

DCHECK(paragraphEnd.isNotNull()) << range.endPosition();

@@ -88,7 +88,7 @@ TextCheckingParagraph::~TextCheckingParagraph()

void TextCheckingParagraph::expandRangeToNextEnd()

{

DCHECK(m_checkingRange.isNotNull());

- setParagraphRange(EphemeralRange(paragraphRange().startPosition(), endOfParagraph(startOfNextParagraph(createVisiblePosition(paragraphRange().startPosition()))).deepEquivalent()));

+ setParagraphRange(EphemeralRange(paragraphRange().startPosition(), endOfParagraph(startOfNextParagraph(createVisiblePositionDeprecated(paragraphRange().startPosition()))).deepEquivalent()));

invalidateParagraphRangeValues();

}