third_party/WebKit/Source/core/editing/PendingSelection.cpp - Issue 2341053002: Mark the createVisiblePosition overloads as deprecated

Unified Diff: third_party/WebKit/Source/core/editing/PendingSelection.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)

Patch Set: minor revision Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/Source/core/editing/DOMSelection.cpp ('K') | « third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp ('k') | third_party/WebKit/Source/core/editing/PlainTextRange.cpp » ('j') | third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/PendingSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/PendingSelection.cpp b/third_party/WebKit/Source/core/editing/PendingSelection.cpp

index a0ce47623cc5323286a52253b4aaef3c798ef531..83161df0c5915ecd620abde5245508e8309ecb51 100644

--- a/third_party/WebKit/Source/core/editing/PendingSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/PendingSelection.cpp

@@ -62,7 +62,7 @@ VisibleSelectionInFlatTree PendingSelection::calcVisibleSelection(const VisibleS

SelectionType selectionType = originalSelection.getSelectionType();

yosin_UTC9 2016/09/16 02:01:21 Let's make |PendingSelection::calcVisbileSelection

const TextAffinity affinity = originalSelection.affinity();

- bool paintBlockCursor = m_frameSelection->shouldShowBlockCursor() && selectionType == SelectionType::CaretSelection && !isLogicalEndOfLine(createVisiblePosition(end, affinity));

+ bool paintBlockCursor = m_frameSelection->shouldShowBlockCursor() && selectionType == SelectionType::CaretSelection && !isLogicalEndOfLine(createVisiblePositionDeprecated(end, affinity));

VisibleSelectionInFlatTree selection;

if (enclosingTextFormControl(start.computeContainerNode())) {

// TODO(yosin) We should use |PositionMoveType::CodePoint| to avoid

@@ -72,13 +72,13 @@ VisibleSelectionInFlatTree PendingSelection::calcVisibleSelection(const VisibleS

return selection;

}

- const VisiblePositionInFlatTree& visibleStart = createVisiblePosition(start, selectionType == SelectionType::RangeSelection ? TextAffinity::Downstream : affinity);

+ const VisiblePositionInFlatTree& visibleStart = createVisiblePositionDeprecated(start, selectionType == SelectionType::RangeSelection ? TextAffinity::Downstream : affinity);

if (paintBlockCursor) {

- VisiblePositionInFlatTree visibleExtent = createVisiblePosition(end, affinity);

+ VisiblePositionInFlatTree visibleExtent = createVisiblePositionDeprecated(end, affinity);

visibleExtent = nextPositionOf(visibleExtent, CanSkipOverEditingBoundary);

return VisibleSelectionInFlatTree(visibleStart, visibleExtent);

}

- const VisiblePositionInFlatTree visibleEnd = createVisiblePosition(end, selectionType == SelectionType::RangeSelection ? TextAffinity::Upstream : affinity);

+ const VisiblePositionInFlatTree visibleEnd = createVisiblePositionDeprecated(end, selectionType == SelectionType::RangeSelection ? TextAffinity::Upstream : affinity);

return VisibleSelectionInFlatTree(visibleStart, visibleEnd);

}