third_party/WebKit/Source/core/editing/PlainTextRange.cpp - Issue 2341053002: Mark the createVisiblePosition overloads as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/PlainTextRange.cpp

Issue 2341053002: Mark the createVisiblePosition overloads as deprecated (Closed)

Patch Set: minor revision Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/PlainTextRange.cpp

diff --git a/third_party/WebKit/Source/core/editing/PlainTextRange.cpp b/third_party/WebKit/Source/core/editing/PlainTextRange.cpp

index 5e0f9e3a5658b435542549d33f3cac89ae3260d1..d0abaa69a3b99f1e1e3a27f05fe8b62422e9bfca 100644

--- a/third_party/WebKit/Source/core/editing/PlainTextRange.cpp

+++ b/third_party/WebKit/Source/core/editing/PlainTextRange.cpp

@@ -113,7 +113,7 @@ EphemeralRange PlainTextRange::createRangeFor(const ContainerNode& scope, GetRan

if (!it.atEnd()) {

textRunEndPosition = it.startPositionInCurrentContainer();

} else {

- Position runEnd = nextPositionOf(createVisiblePosition(textRunStartPosition)).deepEquivalent();

+ Position runEnd = nextPositionOf(createVisiblePositionDeprecated(textRunStartPosition)).deepEquivalent();

if (runEnd.isNotNull())

textRunEndPosition = runEnd;

}