Mark the createVisiblePosition overloads as deprecated

third_party/WebKit/Source/core/editing/DOMSelection.cpp

Index: third_party/WebKit/Source/core/editing/DOMSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/DOMSelection.cpp b/third_party/WebKit/Source/core/editing/DOMSelection.cpp
index efffe135cb72d1e4831f2b29d53c272fd4a0543d..832f6e12a446aaa80374eaedcc3cc3facde9f969 100644
--- a/third_party/WebKit/Source/core/editing/DOMSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/DOMSelection.cpp
@@ -243,7 +243,7 @@ void DOMSelection::collapseToEnd(ExceptionState& exceptionState)
         return;
     }
 
-    m_frame->selection().moveTo(createVisiblePosition(selection.end()));
+    m_frame->selection().moveTo(createVisiblePositionDeprecated(selection.end()));

[yosin_UTC9, 2016/09/16 02:01:21]

Let's use |FrameSelection::moveTo(const Position&, ...)| version and get rid of
|FrameSelection::moveTo(const VisiblePositon&, ...)| version.

 }
 
 void DOMSelection::collapseToStart(ExceptionState& exceptionState)
@@ -258,7 +258,7 @@ void DOMSelection::collapseToStart(ExceptionState& exceptionState)
         return;
     }
 
-    m_frame->selection().moveTo(createVisiblePosition(selection.start()));
+    m_frame->selection().moveTo(createVisiblePositionDeprecated(selection.start()));

[yosin_UTC9, 2016/09/16 02:01:21]

Let's use |FrameSelection::moveTo(const Position&, ...)| version and get rid of
|FrameSelection::moveTo(const VisiblePositon&, ...)| version.

 }
 
 void DOMSelection::empty()
@@ -289,8 +289,8 @@ void DOMSelection::setBaseAndExtent(Node* baseNode, int baseOffset, Node* extent
     if (!isValidForPosition(baseNode) || !isValidForPosition(extentNode))
         return;
 
-    VisiblePosition visibleBase = createVisiblePosition(createPosition(baseNode, baseOffset));
-    VisiblePosition visibleExtent = createVisiblePosition(createPosition(extentNode, extentOffset));
+    VisiblePosition visibleBase = createVisiblePositionDeprecated(createPosition(baseNode, baseOffset));

[yosin_UTC9, 2016/09/16 02:01:21]

Since |VisibleSelection| ctor converts passed |Position| objects to
|VisiblePosition| in |VisibleSelection::validate()|, we can just pass |Position|
to |VisibleSelection| ctor.

[Xiaocheng, 2016/09/16 09:14:00]

We will still be updating layout here if we are going to hoist layout update
calls from VisibleSelection. Anyway, passing Positions to the VS's ctor seems to
lead to simpler code.

+    VisiblePosition visibleExtent = createVisiblePositionDeprecated(createPosition(extentNode, extentOffset));
     const bool selectionHasDirection = true;
     m_frame->selection().setSelection(VisibleSelection(visibleBase, visibleExtent, selectionHasDirection));
 }