Mark the createVisiblePosition overloads as deprecated

third_party/WebKit/Source/core/editing/PendingSelection.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 41 matching lines @@
     const PositionInFlatTree extent = visibleSelection.extent();
     if (extent.isNotNull() && (!extent.isConnected() || extent.document() != document))
         return false;
     return true;
 }
 
 VisibleSelectionInFlatTree PendingSelection::calcVisibleSelection(const VisibleSelectionInFlatTree& originalSelection) const
 {
     const PositionInFlatTree& start = originalSelection.start();
     const PositionInFlatTree& end = originalSelection.end();
     SelectionType selectionType = originalSelection.getSelectionType();

[yosin_UTC9, 2016/09/16 02:01:21]

Let's make |PendingSelection::calcVisbileSelection()| not to use
|createVisbilePositionDeprecaetd()| first. This is called in rendering pipeline
after LayoutClean.

     const TextAffinity affinity = originalSelection.affinity();
 
-    bool paintBlockCursor = m_frameSelection->shouldShowBlockCursor() && selectionType == SelectionType::CaretSelection && !isLogicalEndOfLine(createVisiblePosition(end, affinity));
+    bool paintBlockCursor = m_frameSelection->shouldShowBlockCursor() && selectionType == SelectionType::CaretSelection && !isLogicalEndOfLine(createVisiblePositionDeprecated(end, affinity));
     VisibleSelectionInFlatTree selection;
     if (enclosingTextFormControl(start.computeContainerNode())) {
         // TODO(yosin) We should use |PositionMoveType::CodePoint| to avoid
         // ending paint at middle of character.
         PositionInFlatTree endPosition = paintBlockCursor ? nextPositionOf(originalSelection.extent(), PositionMoveType::CodeUnit) : end;
         selection.setWithoutValidation(start, endPosition);
         return selection;
     }
 
-    const VisiblePositionInFlatTree& visibleStart = createVisiblePosition(start, selectionType == SelectionType::RangeSelection ? TextAffinity::Downstream : affinity);
+    const VisiblePositionInFlatTree& visibleStart = createVisiblePositionDeprecated(start, selectionType == SelectionType::RangeSelection ? TextAffinity::Downstream : affinity);
     if (paintBlockCursor) {
-        VisiblePositionInFlatTree visibleExtent = createVisiblePosition(end, affinity);
+        VisiblePositionInFlatTree visibleExtent = createVisiblePositionDeprecated(end, affinity);
         visibleExtent = nextPositionOf(visibleExtent, CanSkipOverEditingBoundary);
         return VisibleSelectionInFlatTree(visibleStart, visibleExtent);
     }
-    const VisiblePositionInFlatTree visibleEnd = createVisiblePosition(end, selectionType == SelectionType::RangeSelection ? TextAffinity::Upstream : affinity);
+    const VisiblePositionInFlatTree visibleEnd = createVisiblePositionDeprecated(end, selectionType == SelectionType::RangeSelection ? TextAffinity::Upstream : affinity);
     return VisibleSelectionInFlatTree(visibleStart, visibleEnd);
 }
 
 void PendingSelection::commit(LayoutView& layoutView)
 {
     if (!hasPendingSelection())
         return;
     DCHECK(!layoutView.needsLayout());
     m_hasPendingSelection = false;
 
@@ skipping 42 matching lines @@
     DCHECK(layoutView == endLayoutObject->view());
     layoutView.setSelection(startLayoutObject, startPos.computeEditingOffset(), endLayoutObject, endPos.computeEditingOffset());
 }
 
 DEFINE_TRACE(PendingSelection)
 {
     visitor->trace(m_frameSelection);
 }
 
 } // namespace blink