Removing media controls download button feature flag

Removing media controls download button feature flag

BUG=601247
Committed: https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23
Cr-Commit-Position: refs/heads/master@{#419153}

[kdsilva, 2016-09-14 09:42:06]

The CQ bit was checked by kdsilva@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 09:42:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 10:56:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 10:56:42]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kdsilva, 2016-09-14 17:44:30]

The CQ bit was checked by kdsilva@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 17:44:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 17:47:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 17:47:51]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kdsilva, 2016-09-15 08:13:19]

The CQ bit was checked by kdsilva@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 08:13:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 08:16:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 08:16:21]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kdsilva, 2016-09-15 08:39:08]

The CQ bit was checked by kdsilva@google.com to run a CQ dry run

[kdsilva, 2016-09-15 08:39:13]

Patchset #4 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-09-15 08:39:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 09:38:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 09:38:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kdsilva, 2016-09-15 10:32:01]

The CQ bit was checked by kdsilva@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 10:32:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2016-09-15 11:02:46]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-09-15 11:02:47]

https://codereview.chromium.org/2337013005/diff/120001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2337013005/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:238: crbug.com/636239 [ Win7 ]
media/video-zoom-controls.html [ Failure NeedsRebaseline ]
Maybe you could not add NeedsRebaseline here otherwise, I think the bot will
remove NeedsRebaseline and Failure and assume it's now passing.

https://codereview.chromium.org/2337013005/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:1169: crbug.com/487344 [ Win ]
compositing/video/video-controls-layer-creation.html [ Pass Failure
NeedsRebaseline ]
ditto

https://codereview.chromium.org/2337013005/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:1264: # Rebaselining tests with
download button
Don't add a comment. The bots will remove the lines below but will not remove
this comment.

[commit-bot: I haz the power, 2016-09-15 11:54:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 11:54:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Srirama, 2016-09-15 12:23:07]

srirama.m@samsung.com changed reviewers:
+ srirama.m@samsung.com

[Srirama, 2016-09-15 12:23:08]

https://codereview.chromium.org/2337013005/diff/120001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2337013005/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:1265: crbug.com/601247 [ Mac
Linux Win ] virtual/android/fullscreen/video-controls-timeline.html [
NeedsRebaseline ]
don't we need to rebaseline on android port?

[kdsilva, 2016-09-15 13:25:59]

The CQ bit was checked by kdsilva@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 13:26:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kdsilva, 2016-09-15 13:27:12]

Patchset #7 (id:140001) has been deleted

[commit-bot: I haz the power, 2016-09-15 13:28:09]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kdsilva, 2016-09-15 13:28:59]

The CQ bit was checked by kdsilva@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 13:29:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 13:31:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 13:31:43]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kdsilva, 2016-09-15 13:52:30]

The CQ bit was checked by kdsilva@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 13:52:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kdsilva, 2016-09-15 13:52:50]

Patchset #7 (id:160001) has been deleted

[commit-bot: I haz the power, 2016-09-15 14:41:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 14:41:12]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kdsilva, 2016-09-15 15:26:26]

The CQ bit was checked by kdsilva@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 15:26:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 15:29:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 15:29:29]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kdsilva, 2016-09-15 15:35:30]

The CQ bit was checked by kdsilva@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 15:35:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kdsilva, 2016-09-15 15:52:18]

The CQ bit was checked by kdsilva@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 15:52:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kdsilva, 2016-09-15 17:00:03]

kdsilva@google.com changed reviewers:
+ avayvod@chromium.org

[kdsilva, 2016-09-15 17:00:04]

PTAL :)

[commit-bot: I haz the power, 2016-09-15 17:34:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 17:34:07]

Dry run: This issue passed the CQ dry run.

[whywhat, 2016-09-15 18:29:48]

lgtm

https://codereview.chromium.org/2337013005/diff/240001/chrome/android/javates...
File
chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java
(right):

https://codereview.chromium.org/2337013005/diff/240001/chrome/android/javates...
chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java:538:
private Rect downloadButton(Rect videoRect) {
any thoughts on how this could be made agnostic to changes to the media
controls? (no action needed for this CL)

https://codereview.chromium.org/2337013005/diff/240001/chrome/test/data/andro...
File chrome/test/data/android/media/simple_video.html (right):

https://codereview.chromium.org/2337013005/diff/240001/chrome/test/data/andro...
chrome/test/data/android/media/simple_video.html:4: <video src="test.webm"
controls id="video" width=500></video>
nit: add a comment for the width to explain we don't support the overlay button

https://codereview.chromium.org/2337013005/diff/240001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/media/track/track-cue-rendering-after-controls-added-expected.html
(right):

https://codereview.chromium.org/2337013005/diff/240001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/media/track/track-cue-rendering-after-controls-added-expected.html:8:
<video controls style="border:1px solid gray; width: 500px;">
ditto

https://codereview.chromium.org/2337013005/diff/240001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/media/track/track-cue-rendering-after-controls-added.html
(right):

https://codereview.chromium.org/2337013005/diff/240001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/media/track/track-cue-rendering-after-controls-added.html:8:
<video style="border:1px solid gray; width: 500px;">
nit: ditto

[kdsilva, 2016-09-16 10:14:58]

kdsilva@google.com changed reviewers:
+ foolip@chromium.org

[kdsilva, 2016-09-16 10:14:59]

@foolip: Could you rubber stamp the Webkit code?

I'm in the process of applying @avayvod's changes, but if you could take a look
in the meantime that would be great!

[kdsilva, 2016-09-16 10:21:44]

The CQ bit was checked by kdsilva@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 10:21:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-09-16 11:15:22]

rs lgtm for when the other reviewers are happy

[kdsilva, 2016-09-16 11:28:58]

https://codereview.chromium.org/2337013005/diff/240001/chrome/test/data/andro...
File chrome/test/data/android/media/simple_video.html (right):

https://codereview.chromium.org/2337013005/diff/240001/chrome/test/data/andro...
chrome/test/data/android/media/simple_video.html:4: <video src="test.webm"
controls id="video" width=500></video>
On 2016/09/15 18:29:48, whywhat wrote:
> nit: add a comment for the width to explain we don't support the overlay
button

Done.

https://codereview.chromium.org/2337013005/diff/240001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/media/track/track-cue-rendering-after-controls-added-expected.html
(right):

https://codereview.chromium.org/2337013005/diff/240001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/media/track/track-cue-rendering-after-controls-added-expected.html:8:
<video controls style="border:1px solid gray; width: 500px;">
On 2016/09/15 18:29:48, whywhat wrote:
> ditto

Done.

https://codereview.chromium.org/2337013005/diff/240001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/media/track/track-cue-rendering-after-controls-added.html
(right):

https://codereview.chromium.org/2337013005/diff/240001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/media/track/track-cue-rendering-after-controls-added.html:8:
<video style="border:1px solid gray; width: 500px;">
On 2016/09/15 18:29:48, whywhat wrote:
> nit: ditto

Done.

[commit-bot: I haz the power, 2016-09-16 12:21:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 12:21:39]

Dry run: This issue passed the CQ dry run.

[kdsilva, 2016-09-16 13:01:09]

The CQ bit was checked by kdsilva@google.com

[kdsilva, 2016-09-16 13:01:10]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/2337013005/#ps260001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-09-16 13:01:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 13:06:38]

Committed patchset #11 (id:260001)

[commit-bot: I haz the power, 2016-09-16 13:09:13]

Description was changed from

==========
Removing media controls download button feature flag

BUG=601247
==========

to

==========
Removing media controls download button feature flag

BUG=601247

Committed: https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23
Cr-Commit-Position: refs/heads/master@{#419153}
==========

[commit-bot: I haz the power, 2016-09-16 13:09:15]

Patchset 11 (id:??) landed as
https://crrev.com/6c4ad33831899ad35888e65ae473a27a0c817e23
Cr-Commit-Position: refs/heads/master@{#419153}