third_party/WebKit/LayoutTests/media/video-controls-download-button-displayed.html - Issue 2337013005: Removing media controls download button feature flag

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-controls-download-button-displayed.html

Issue 2337013005: Removing media controls download button feature flag (Closed)

Patch Set: addressed comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cue-rendering-after-controls-added-expected.html ('k') | third_party/WebKit/LayoutTests/media/video-controls-download-button-saves-media.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Download button should appear for videos that can be downloaded.</title>	2 <title>Download button should appear for videos that can be downloaded.</title>

3 <script src="../resources/testharness.js"></script>	3 <script src="../resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>	4 <script src="../resources/testharnessreport.js"></script>

5 <script src="media-controls.js"></script>	5 <script src="media-controls.js"></script>

6 <script src="media-file.js"></script>	6 <script src="media-file.js"></script>

7 <!--Padding ensures the overflow menu is visible for the tests. -->	7 <!--Padding ensures the overflow menu is visible for the tests. -->

8 <body style="padding-top: 200px; padding-left: 100px">	8 <body style="padding-top: 200px; padding-left: 100px">

9 <video controls></video>	9 <video controls></video>

10 <script>	10 <script>

11 async_test(function(t) {	11 async_test(function(t) {

12 if (window.internals)

13 window.internals.runtimeFlags.mediaControlsDownloadButtonEnabled = true;

14 // Set up video	12 // Set up video

15 var video = document.querySelector("video");	13 var video = document.querySelector("video");

16 video.src = findMediaFile("video", "content/test");	14 video.src = findMediaFile("video", "content/test");

17 var controlID = "-internal-download-button";	15 var controlID = "-internal-download-button";

18 var downloadButton = mediaControlsElement(internals.shadowRoot(video).firstChi ld, controlID);	16 var downloadButton = mediaControlsElement(internals.shadowRoot(video).firstChi ld, controlID);

19 video.onloadeddata = t.step_func_done(function() {	17 video.onloadeddata = t.step_func_done(function() {

20 assert_not_equals(getComputedStyle(downloadButton).display, "none");	18 assert_not_equals(getComputedStyle(downloadButton).display, "none");

21 });	19 });

22 });	20 });

23 </script>	21 </script>

24 </body>	22 </body>

OLD	NEW