Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2337013005: Removing media controls download button feature flag (Closed)
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 m_timeline->setPosition(mediaElement().currentTime()); 300 m_timeline->setPosition(mediaElement().currentTime());
301 301
302 updateVolume(); 302 updateVolume();
303 303
304 refreshClosedCaptionsButtonVisibility(); 304 refreshClosedCaptionsButtonVisibility();
305 305
306 m_fullscreenButton->setIsWanted(shouldShowFullscreenButton(mediaElement())); 306 m_fullscreenButton->setIsWanted(shouldShowFullscreenButton(mediaElement()));
307 307
308 refreshCastButtonVisibilityWithoutUpdate(); 308 refreshCastButtonVisibilityWithoutUpdate();
309 309
310 if (RuntimeEnabledFeatures::mediaControlsDownloadButtonEnabled()) 310 m_downloadButton->setIsWanted(m_downloadButton->shouldDisplayDownloadButton( ));
311 m_downloadButton->setIsWanted(m_downloadButton->shouldDisplayDownloadBut ton());
312 } 311 }
313 312
314 LayoutObject* MediaControls::layoutObjectForTextTrackLayout() 313 LayoutObject* MediaControls::layoutObjectForTextTrackLayout()
315 { 314 {
316 return m_panel->layoutObject(); 315 return m_panel->layoutObject();
317 } 316 }
318 317
319 void MediaControls::show() 318 void MediaControls::show()
320 { 319 {
321 makeOpaque(); 320 makeOpaque();
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
867 visitor->trace(m_enclosure); 866 visitor->trace(m_enclosure);
868 visitor->trace(m_textTrackList); 867 visitor->trace(m_textTrackList);
869 visitor->trace(m_overflowMenu); 868 visitor->trace(m_overflowMenu);
870 visitor->trace(m_overflowList); 869 visitor->trace(m_overflowList);
871 visitor->trace(m_castButton); 870 visitor->trace(m_castButton);
872 visitor->trace(m_overlayCastButton); 871 visitor->trace(m_overlayCastButton);
873 HTMLDivElement::trace(visitor); 872 HTMLDivElement::trace(visitor);
874 } 873 }
875 874
876 } // namespace blink 875 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698