third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-correct-ordering.html - Issue 2337013005: Removing media controls download button feature flag

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-correct-ordering.html

Issue 2337013005: Removing media controls download button feature flag (Closed)

Patch Set: addressed comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-controls-download-button-saves-media.html ('k') | third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-download-button.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Overflow menu children appear in correct order.</title>	2 <title>Overflow menu children appear in correct order.</title>

3 <script src="../resources/testharness.js"></script>	3 <script src="../resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>	4 <script src="../resources/testharnessreport.js"></script>

5 <script src="media-controls.js"></script>	5 <script src="media-controls.js"></script>

6 <script src="media-file.js"></script>	6 <script src="media-file.js"></script>

7 <script src="overflow-menu.js"></script>	7 <script src="overflow-menu.js"></script>

8	8

9 <!--Padding ensures the overflow menu is visible for the tests. -->	9 <!--Padding ensures the overflow menu is visible for the tests. -->

10 <body style="padding-top: 200px; padding-left: 100px">	10 <body style="padding-top: 200px; padding-left: 100px">

11 <video controls></video>	11 <video controls></video>

12 <script>	12 <script>

13 async_test(function(t) {	13 async_test(function(t) {

14 if (window.internals)

15 window.internals.runtimeFlags.mediaControlsDownloadButtonEnabled = true;

16 // Set up video	14 // Set up video

17 var video = document.querySelector("video");	15 var video = document.querySelector("video");

18 video.src = findMediaFile("video", "content/test");	16 video.src = findMediaFile("video", "content/test");

19 video.setAttribute("width", "60");	17 video.setAttribute("width", "60");

20 // Add captions	18 // Add captions

21 var track = video.addTextTrack("captions");	19 var track = video.addTextTrack("captions");

22 // Pretend we have a cast device	20 // Pretend we have a cast device

23 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, true);	21 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, true);

24	22

25 video.onloadeddata = t.step_func_done(function() {	23 video.onloadeddata = t.step_func_done(function() {

(...skipping 12 matching lines...) Expand all Loading...
38 assert_equals(internals.shadowPseudoId(innerButton), overflowButtonsCSS[i] );	36 assert_equals(internals.shadowPseudoId(innerButton), overflowButtonsCSS[i] );

39 // Items should be visible	37 // Items should be visible

40 assert_not_equals(getComputedStyle(child).display, "none");	38 assert_not_equals(getComputedStyle(child).display, "none");

41 // Buttons shouldn't be visible	39 // Buttons shouldn't be visible

42 assert_equals(getComputedStyle(innerButton).display, "none");	40 assert_equals(getComputedStyle(innerButton).display, "none");

43 }	41 }

44 });	42 });

45 });	43 });

46 </script>	44 </script>

47 </body>	45 </body>

OLD	NEW