Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2343133002: Rebaselining Win10 with download button. (Closed)

Created:
4 years, 3 months ago by kdsilva
Modified:
4 years, 3 months ago
Reviewers:
whywhat, iclelland
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaselining Win10 with media controls download button. This CL is a follow up to https://codereview.chromium.org/2337013005 NOTRY=true NOTREECHECKS=true BUG=601247 Committed: https://crrev.com/e34a6457a83b0d60dda1ce4776e84eeee2e97aa6 Cr-Commit-Position: refs/heads/master@{#419181}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 32 (26 generated)
kdsilva
PTAL :)
4 years, 3 months ago (2016-09-16 15:00:06 UTC) #9
whywhat
Ian, it seems from the sheriff-o-matic that we need to add some more bots for ...
4 years, 3 months ago (2016-09-16 15:09:18 UTC) #16
iclelland
On 2016/09/16 15:09:18, whywhat wrote: > Ian, it seems from the sheriff-o-matic that we need ...
4 years, 3 months ago (2016-09-16 15:18:43 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343133002/80001
4 years, 3 months ago (2016-09-16 16:03:57 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-16 16:08:40 UTC) #30
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 16:12:22 UTC) #32
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e34a6457a83b0d60dda1ce4776e84eeee2e97aa6
Cr-Commit-Position: refs/heads/master@{#419181}

Powered by Google App Engine
This is Rietveld 408576698