|
|
DescriptionRebaselining Win10 with media controls download button.
This CL is a follow up to https://codereview.chromium.org/2337013005
NOTRY=true
NOTREECHECKS=true
BUG=601247
Committed: https://crrev.com/e34a6457a83b0d60dda1ce4776e84eeee2e97aa6
Cr-Commit-Position: refs/heads/master@{#419181}
Patch Set 1 #Patch Set 2 : rebased #Patch Set 3 : rebased #Patch Set 4 : rebased #Patch Set 5 : rebased #Messages
Total messages: 32 (26 generated)
The CQ bit was checked by kdsilva@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kdsilva@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Rebaselining Win10 with download button. BUG=601247 ========== to ========== Rebaselining Win10 with media controls download button. This CL is a follow up to https://codereview.chromium.org/2337013005 BUG=601247 ==========
kdsilva@google.com changed reviewers: + avayvod@chromium.org, iclelland@chromium.org
PTAL :)
Description was changed from ========== Rebaselining Win10 with media controls download button. This CL is a follow up to https://codereview.chromium.org/2337013005 BUG=601247 ========== to ========== Rebaselining Win10 with media controls download button. This CL is a follow up to https://codereview.chromium.org/2337013005 NOTRY=true NOTREECHECKS=true BUG=601247 ==========
The CQ bit was unchecked by kdsilva@google.com
The CQ bit was checked by kdsilva@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Ian, it seems from the sheriff-o-matic that we need to add some more bots for this test and another test that's failing? WebKit Linux WebKit Linux (dbg) WebKit Mac10.10 WebKit Mac10.11 virtual/rootlayerscrolls/scrollbars/custom-scrollbar-reconstruction-on-inserting-style-sheet.html WebKit Win10 And win10_blink_rel for both tests? Not familiar with rebaselining and sheriff-o-matic for these tests to know for sure :) Otherwise, lgtm so Krittika could submit at her convenience.
On 2016/09/16 15:09:18, whywhat wrote: > Ian, it seems from the sheriff-o-matic that we need to add some more bots for > this test and another test that's failing? > > WebKit Linux > WebKit Linux (dbg) > > WebKit Mac10.10 > WebKit Mac10.11 > > virtual/rootlayerscrolls/scrollbars/custom-scrollbar-reconstruction-on-inserting-style-sheet.html > > WebKit Win10 Yes, I think that one should just have the specific platforms removed from the expectation. It looks like it was a merge conflict with https://chromium.googlesource.com/chromium/src/+/1fd6bb0620f889ba8dd8a9b620b8... from yesterday. > > And > > win10_blink_rel for both tests? > > Not familiar with rebaselining and sheriff-o-matic for these tests to know for > sure :) > > Otherwise, lgtm so Krittika could submit at her convenience. I think just "Win" should be sufficient to match any and all windows builders for media-zoom-controls. Thanks!
The CQ bit was checked by kdsilva@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kdsilva@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kdsilva@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org Link to the patchset: https://codereview.chromium.org/2343133002/#ps80001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Rebaselining Win10 with media controls download button. This CL is a follow up to https://codereview.chromium.org/2337013005 NOTRY=true NOTREECHECKS=true BUG=601247 ========== to ========== Rebaselining Win10 with media controls download button. This CL is a follow up to https://codereview.chromium.org/2337013005 NOTRY=true NOTREECHECKS=true BUG=601247 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Rebaselining Win10 with media controls download button. This CL is a follow up to https://codereview.chromium.org/2337013005 NOTRY=true NOTREECHECKS=true BUG=601247 ========== to ========== Rebaselining Win10 with media controls download button. This CL is a follow up to https://codereview.chromium.org/2337013005 NOTRY=true NOTREECHECKS=true BUG=601247 Committed: https://crrev.com/e34a6457a83b0d60dda1ce4776e84eeee2e97aa6 Cr-Commit-Position: refs/heads/master@{#419181} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/e34a6457a83b0d60dda1ce4776e84eeee2e97aa6 Cr-Commit-Position: refs/heads/master@{#419181} |