Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2336103003: Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. (Closed)

Created:
4 years, 3 months ago by krasin1
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, blink-reviews-html_chromium.org, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-css, sof, eae+blinkwatch, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, blink-reviews-layout_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. We're at 80% of the blacklist converted. BUG=641536 TBR=eae@chromium.org Committed: https://crrev.com/e49ebf8c7b37e7d6d4868f93cd60d239d97a4abf Cr-Commit-Position: refs/heads/master@{#418361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -26 lines) Patch
M third_party/WebKit/Source/core/css/ElementRuleCollector.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 5 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCollection.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/cfi/blacklist.txt View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336103003/1
4 years, 3 months ago (2016-09-13 20:44:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 20:50:07 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e49ebf8c7b37e7d6d4868f93cd60d239d97a4abf Cr-Commit-Position: refs/heads/master@{#418361}
4 years, 3 months ago (2016-09-13 20:52:53 UTC) #12
krasin1
(adding manually, as TBR=eae@chromium.org didn't trigger an email)
4 years, 3 months ago (2016-09-13 20:54:14 UTC) #14
eae
4 years, 3 months ago (2016-09-15 09:25:58 UTC) #15
Message was sent while issue was closed.
LGTM (post facto)

Powered by Google App Engine
This is Rietveld 408576698