Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/Source/core/dom/ContainerNode.cpp

Issue 2336103003: Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ContainerNode.cpp
diff --git a/third_party/WebKit/Source/core/dom/ContainerNode.cpp b/third_party/WebKit/Source/core/dom/ContainerNode.cpp
index 7576baa22180d57c119de8b984213a2fbd96eb5c..34ea3c648ad960c9b12c453150eff5b0bf9e85af 100644
--- a/third_party/WebKit/Source/core/dom/ContainerNode.cpp
+++ b/third_party/WebKit/Source/core/dom/ContainerNode.cpp
@@ -90,6 +90,7 @@ ContainerNode::~ContainerNode()
DCHECK(needsAttach());
}
+DISABLE_CFI_PERF
bool ContainerNode::isChildTypeAllowed(const Node& child) const
{
if (!child.isDocumentFragment())
@@ -109,6 +110,7 @@ bool ContainerNode::containsConsideringHostElements(const Node& newChild) const
return newChild.contains(this);
}
+DISABLE_CFI_PERF
bool ContainerNode::checkAcceptChild(const Node* newChild, const Node* oldChild, ExceptionState& exceptionState) const
{
// Not mentioned in spec: throw NotFoundError if newChild is null
@@ -672,6 +674,7 @@ void ContainerNode::parserAppendChild(Node* newChild)
notifyNodeInserted(*newChild, ChildrenChangeSourceParser);
}
+DISABLE_CFI_PERF
void ContainerNode::notifyNodeInserted(Node& root, ChildrenChangeSource source)
{
#if DCHECK_IS_ON()
@@ -695,6 +698,7 @@ void ContainerNode::notifyNodeInserted(Node& root, ChildrenChangeSource source)
}
}
+DISABLE_CFI_PERF
void ContainerNode::notifyNodeInsertedInternal(Node& root, NodeVector& postInsertionNotificationTargets)
{
EventDispatchForbiddenScope assertNoEventDispatch;
@@ -729,6 +733,7 @@ void ContainerNode::notifyNodeRemoved(Node& root)
}
}
+DISABLE_CFI_PERF
void ContainerNode::attachLayoutTree(const AttachContext& context)
{
AttachContext childrenContext(context);
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp ('k') | third_party/WebKit/Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698