third_party/WebKit/Source/core/dom/Node.h - Issue 2336103003: Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.h

Issue 2336103003: Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Node.h

diff --git a/third_party/WebKit/Source/core/dom/Node.h b/third_party/WebKit/Source/core/dom/Node.h

index 42650c6b2bf21868317c5596976eacef2459fc18..86a3aab569ce1ec0d185c8a768a353d2ba002f60 100644

--- a/third_party/WebKit/Source/core/dom/Node.h

+++ b/third_party/WebKit/Source/core/dom/Node.h

@@ -251,10 +251,10 @@ public:

bool isHTMLElement() const { return getFlag(IsHTMLFlag); }

bool isSVGElement() const { return getFlag(IsSVGFlag); }

- bool isPseudoElement() const { return getPseudoId() != PseudoIdNone; }

- bool isBeforePseudoElement() const { return getPseudoId() == PseudoIdBefore; }

- bool isAfterPseudoElement() const { return getPseudoId() == PseudoIdAfter; }

- bool isFirstLetterPseudoElement() const { return getPseudoId() == PseudoIdFirstLetter; }

+ DISABLE_CFI_PERF bool isPseudoElement() const { return getPseudoId() != PseudoIdNone; }

+ DISABLE_CFI_PERF bool isBeforePseudoElement() const { return getPseudoId() == PseudoIdBefore; }

+ DISABLE_CFI_PERF bool isAfterPseudoElement() const { return getPseudoId() == PseudoIdAfter; }

+ DISABLE_CFI_PERF bool isFirstLetterPseudoElement() const { return getPseudoId() == PseudoIdFirstLetter; }

virtual PseudoId getPseudoId() const { return PseudoIdNone; }

CustomElementState getCustomElementState() const { return static_cast<CustomElementState>(m_nodeFlags & CustomElementStateMask); }