Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp

Issue 2336103003: Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 collectDestinationInsertionPoints(candidate, candidateInsertionPoints); 190 collectDestinationInsertionPoints(candidate, candidateInsertionPoints);
191 if (insertionPoints.size() != candidateInsertionPoints.size()) 191 if (insertionPoints.size() != candidateInsertionPoints.size())
192 return false; 192 return false;
193 for (size_t i = 0; i < insertionPoints.size(); ++i) { 193 for (size_t i = 0; i < insertionPoints.size(); ++i) {
194 if (insertionPoints[i] != candidateInsertionPoints[i]) 194 if (insertionPoints[i] != candidateInsertionPoints[i])
195 return false; 195 return false;
196 } 196 }
197 return true; 197 return true;
198 } 198 }
199 199
200 DISABLE_CFI_PERF
200 bool SharedStyleFinder::canShareStyleWithElement(Element& candidate) const 201 bool SharedStyleFinder::canShareStyleWithElement(Element& candidate) const
201 { 202 {
202 if (element() == candidate) 203 if (element() == candidate)
203 return false; 204 return false;
204 Element* parent = candidate.parentOrShadowHostElement(); 205 Element* parent = candidate.parentOrShadowHostElement();
205 const ComputedStyle* style = candidate.computedStyle(); 206 const ComputedStyle* style = candidate.computedStyle();
206 if (!style) 207 if (!style)
207 return false; 208 return false;
208 if (!style->isSharable()) 209 if (!style->isSharable())
209 return false; 210 return false;
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 // Tracking child index requires unique style for each node. This may get se t by the sibling rule match above. 351 // Tracking child index requires unique style for each node. This may get se t by the sibling rule match above.
351 if (!element().parentElementOrShadowRoot()->childrenSupportStyleSharing()) { 352 if (!element().parentElementOrShadowRoot()->childrenSupportStyleSharing()) {
352 INCREMENT_STYLE_STATS_COUNTER(document().styleEngine(), sharedStyleRejec tedByParent, 1); 353 INCREMENT_STYLE_STATS_COUNTER(document().styleEngine(), sharedStyleRejec tedByParent, 1);
353 return nullptr; 354 return nullptr;
354 } 355 }
355 356
356 return shareElement->mutableComputedStyle(); 357 return shareElement->mutableComputedStyle();
357 } 358 }
358 359
359 } // namespace blink 360 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698