Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: third_party/WebKit/Source/core/events/EventTarget.h

Issue 2336103003: Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 6 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
7 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org> 7 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 else { \ 237 else { \
238 DCHECK(eventTarget.toLocalDOMWindow()); \ 238 DCHECK(eventTarget.toLocalDOMWindow()); \
239 eventTarget.setAttributeEventListener(EventTypeNames::attribute, lis tener); \ 239 eventTarget.setAttributeEventListener(EventTypeNames::attribute, lis tener); \
240 } \ 240 } \
241 } 241 }
242 242
243 #define DEFINE_MAPPED_ATTRIBUTE_EVENT_LISTENER(attribute, eventName) \ 243 #define DEFINE_MAPPED_ATTRIBUTE_EVENT_LISTENER(attribute, eventName) \
244 EventListener* on##attribute() { return getAttributeEventListener(EventTypeN ames::eventName); } \ 244 EventListener* on##attribute() { return getAttributeEventListener(EventTypeN ames::eventName); } \
245 void setOn##attribute(EventListener* listener) { setAttributeEventListener(E ventTypeNames::eventName, listener); } \ 245 void setOn##attribute(EventListener* listener) { setAttributeEventListener(E ventTypeNames::eventName, listener); } \
246 246
247 DISABLE_CFI_PERF
247 inline bool EventTarget::hasEventListeners() const 248 inline bool EventTarget::hasEventListeners() const
248 { 249 {
249 // FIXME: We should have a const version of eventTargetData. 250 // FIXME: We should have a const version of eventTargetData.
250 if (const EventTargetData* d = const_cast<EventTarget*>(this)->eventTargetDa ta()) 251 if (const EventTargetData* d = const_cast<EventTarget*>(this)->eventTargetDa ta())
251 return !d->eventListenerMap.isEmpty(); 252 return !d->eventListenerMap.isEmpty();
252 return false; 253 return false;
253 } 254 }
254 255
256 DISABLE_CFI_PERF
255 inline bool EventTarget::hasEventListeners(const AtomicString& eventType) const 257 inline bool EventTarget::hasEventListeners(const AtomicString& eventType) const
256 { 258 {
257 // FIXME: We should have const version of eventTargetData. 259 // FIXME: We should have const version of eventTargetData.
258 if (const EventTargetData* d = const_cast<EventTarget*>(this)->eventTargetDa ta()) 260 if (const EventTargetData* d = const_cast<EventTarget*>(this)->eventTargetDa ta())
259 return d->eventListenerMap.contains(eventType); 261 return d->eventListenerMap.contains(eventType);
260 return false; 262 return false;
261 } 263 }
262 264
263 inline bool EventTarget::hasCapturingEventListeners(const AtomicString& eventTyp e) 265 inline bool EventTarget::hasCapturingEventListeners(const AtomicString& eventTyp e)
264 { 266 {
265 EventTargetData* d = eventTargetData(); 267 EventTargetData* d = eventTargetData();
266 if (!d) 268 if (!d)
267 return false; 269 return false;
268 return d->eventListenerMap.containsCapturing(eventType); 270 return d->eventListenerMap.containsCapturing(eventType);
269 } 271 }
270 272
271 } // namespace blink 273 } // namespace blink
272 274
273 #endif // EventTarget_h 275 #endif // EventTarget_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.cpp ('k') | third_party/WebKit/Source/core/html/HTMLCollection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698