CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

As a result, we will get many (*:1 relationship) collections of animations for each element
(animation's target).

This a part of the plan to make ElementAnimations a hidden
and passive entity (not presented in API and unit tests).

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis
(so AnimationHost works with a list of active
AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/db00688793f63e1f3ccd71f883ec3129bd169abe
Cr-Commit-Position: refs/heads/master@{#418439}

[loyso (OOO), 2016-09-13 00:27:30]

Description was changed from

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

BUG=592873
==========

to

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-09-13 00:27:51]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[loyso (OOO), 2016-09-13 00:28:02]

Description was changed from

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-09-13 00:28:02]

loyso@chromium.org changed reviewers:
+ ajuma@chromium.org

[commit-bot: I haz the power, 2016-09-13 00:28:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[loyso (OOO), 2016-09-13 00:29:39]

loyso@chromium.org changed reviewers:
+ vollick@chromium.org

[loyso (OOO), 2016-09-13 01:33:55]

Description was changed from

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-09-13 01:37:26]

Description was changed from

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList has a
callback mechanism
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-09-13 01:38:04]

Description was changed from

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList has a
callback mechanism
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-09-13 01:44:07]

Description was changed from

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis (so AnimationHost works with a
list of active AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-09-13 01:44:29]

Description was changed from

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis (so AnimationHost works with a
list of active AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis
(so AnimationHost works with a list of active
AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-09-13 01:47:43]

Description was changed from

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis
(so AnimationHost works with a list of active
AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

As a result, we will get many (1:*) collections of animations for each element
(animation's target)

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis
(so AnimationHost works with a list of active
AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-09-13 01:48:36]

Description was changed from

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

As a result, we will get many (1:*) collections of animations for each element
(animation's target)

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis
(so AnimationHost works with a list of active
AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

As a result, we will get many (*:1 relationship) collections of animations for
each element
(animation's target).

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis
(so AnimationHost works with a list of active
AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-09-13 01:52:41]

Description was changed from

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

As a result, we will get many (*:1 relationship) collections of animations for
each element
(animation's target).

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis
(so AnimationHost works with a list of active
AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

As a result, we will get many (*:1 relationship) collections of animations for
each element
(animation's target).

This a part of the plan to make ElementAnimations a hidden
and passive entity (not presented in API and unit tests).

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis
(so AnimationHost works with a list of active
AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-09-13 07:41:35]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 07:41:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[loyso (OOO), 2016-09-13 07:43:51]

ajuma@, cc/ please!
vollick@, ui/compositor/ please!

[commit-bot: I haz the power, 2016-09-13 09:02:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 09:02:50]

Dry run: This issue passed the CQ dry run.

[ajuma, 2016-09-13 17:19:16]

lgtm

https://codereview.chromium.org/2335043002/diff/40001/cc/animation/element_an...
File cc/animation/element_animations.h (right):

https://codereview.chromium.org/2335043002/diff/40001/cc/animation/element_an...
cc/animation/element_animations.h:183: // TODO(loyso): Rework
UpdateClientAnimationState to use bitset.
Agreed. In particular, the version below that takes a triple of bools is going
to be confusing for callers.

https://codereview.chromium.org/2335043002/diff/40001/cc/animation/element_an...
cc/animation/element_animations.h:270: bool
needs_update_impl_client_state_filter_ : 1;
These need to be initialized.

[Ian Vollick, 2016-09-13 17:20:27]

On 2016/09/13 17:19:16, ajuma wrote:
> lgtm
> 
>
https://codereview.chromium.org/2335043002/diff/40001/cc/animation/element_an...
> File cc/animation/element_animations.h (right):
> 
>
https://codereview.chromium.org/2335043002/diff/40001/cc/animation/element_an...
> cc/animation/element_animations.h:183: // TODO(loyso): Rework
> UpdateClientAnimationState to use bitset.
> Agreed. In particular, the version below that takes a triple of bools is going
> to be confusing for callers.
> 
>
https://codereview.chromium.org/2335043002/diff/40001/cc/animation/element_an...
> cc/animation/element_animations.h:270: bool
> needs_update_impl_client_state_filter_ : 1;
> These need to be initialized.

ui/compositor lgtm.

[loyso (OOO), 2016-09-14 00:20:07]

https://codereview.chromium.org/2335043002/diff/40001/cc/animation/element_an...
File cc/animation/element_animations.h (right):

https://codereview.chromium.org/2335043002/diff/40001/cc/animation/element_an...
cc/animation/element_animations.h:183: // TODO(loyso): Rework
UpdateClientAnimationState to use bitset.
On 2016/09/13 17:19:16, ajuma wrote:
> Agreed. In particular, the version below that takes a triple of bools is going
> to be confusing for callers.

Acknowledged.

https://codereview.chromium.org/2335043002/diff/40001/cc/animation/element_an...
cc/animation/element_animations.h:270: bool
needs_update_impl_client_state_filter_ : 1;
On 2016/09/13 17:19:16, ajuma wrote:
> These need to be initialized.
It is initialized. See ClearNeedsUpdateImplClientState() call in the ctor.

[loyso (OOO), 2016-09-14 00:25:17]

The CQ bit was checked by loyso@chromium.org

[commit-bot: I haz the power, 2016-09-14 00:25:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 00:32:08]

Description was changed from

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

As a result, we will get many (*:1 relationship) collections of animations for
each element
(animation's target).

This a part of the plan to make ElementAnimations a hidden
and passive entity (not presented in API and unit tests).

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis
(so AnimationHost works with a list of active
AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

As a result, we will get many (*:1 relationship) collections of animations for
each element
(animation's target).

This a part of the plan to make ElementAnimations a hidden
and passive entity (not presented in API and unit tests).

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis
(so AnimationHost works with a list of active
AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-14 00:32:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-14 00:33:45]

Description was changed from

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

As a result, we will get many (*:1 relationship) collections of animations for
each element
(animation's target).

This a part of the plan to make ElementAnimations a hidden
and passive entity (not presented in API and unit tests).

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis
(so AnimationHost works with a list of active
AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Move animations_ from ElementAnimations to AnimationPlayer.

- Also move all accompanying methods.
- We don't have a notion of pending animations anymore.

As a result, we will get many (*:1 relationship) collections of animations for
each element
(animation's target).

This a part of the plan to make ElementAnimations a hidden
and passive entity (not presented in API and unit tests).

Next steps (separate CLs):
- Shouldn't manually iterate through the list if base::ObserverList
(http://crbug.com/634916)
- Rework all UpdateClientAnimationState callers to use bitset.
- Remove AnimationPlayer::animations() getter
- Change activation to be on a per-player basis
(so AnimationHost works with a list of active
AnimationPlayers rather than ElementAnimations)
- CompositorPlayer::addAnimation should consume unique_ptr.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/db00688793f63e1f3ccd71f883ec3129bd169abe
Cr-Commit-Position: refs/heads/master@{#418439}
==========

[commit-bot: I haz the power, 2016-09-14 00:33:47]

Patchset 3 (id:??) landed as
https://crrev.com/db00688793f63e1f3ccd71f883ec3129bd169abe
Cr-Commit-Position: refs/heads/master@{#418439}