| Index: cc/trees/layer_tree_host_common_unittest.cc
|
| diff --git a/cc/trees/layer_tree_host_common_unittest.cc b/cc/trees/layer_tree_host_common_unittest.cc
|
| index 3f4354c3611433bb998a224e53df87057861f9d6..61d35949cbcf9650d1ea340d68d3f9c8e762a3fb 100644
|
| --- a/cc/trees/layer_tree_host_common_unittest.cc
|
| +++ b/cc/trees/layer_tree_host_common_unittest.cc
|
| @@ -7078,9 +7078,29 @@ TEST_F(LayerTreeHostCommonTest, MaximumAnimationScaleFactor) {
|
| host_impl.animation_host()->AddAnimationTimeline(timeline);
|
|
|
| host_impl.active_tree()->SetElementIdsForTesting();
|
| - AddAnimatedTransformToElementWithPlayer(parent_raw->element_id(), timeline,
|
| - 1.0, TransformOperations(),
|
| - translation);
|
| +
|
| + scoped_refptr<AnimationPlayer> grand_parent_player =
|
| + AnimationPlayer::Create(AnimationIdProvider::NextPlayerId());
|
| + timeline->AttachPlayer(grand_parent_player);
|
| + grand_parent_player->AttachElement(grand_parent_raw->element_id());
|
| +
|
| + scoped_refptr<AnimationPlayer> parent_player =
|
| + AnimationPlayer::Create(AnimationIdProvider::NextPlayerId());
|
| + timeline->AttachPlayer(parent_player);
|
| + parent_player->AttachElement(parent_raw->element_id());
|
| +
|
| + scoped_refptr<AnimationPlayer> child_player =
|
| + AnimationPlayer::Create(AnimationIdProvider::NextPlayerId());
|
| + timeline->AttachPlayer(child_player);
|
| + child_player->AttachElement(child_raw->element_id());
|
| +
|
| + scoped_refptr<AnimationPlayer> grand_child_player =
|
| + AnimationPlayer::Create(AnimationIdProvider::NextPlayerId());
|
| + timeline->AttachPlayer(grand_child_player);
|
| + grand_child_player->AttachElement(grand_child_raw->element_id());
|
| +
|
| + AddAnimatedTransformToPlayer(parent_player.get(), 1.0, TransformOperations(),
|
| + translation);
|
|
|
| // No layers have scale-affecting animations.
|
| EXPECT_EQ(0.f, GetMaximumAnimationScale(grand_parent_raw));
|
| @@ -7096,8 +7116,8 @@ TEST_F(LayerTreeHostCommonTest, MaximumAnimationScaleFactor) {
|
| TransformOperations scale;
|
| scale.AppendScale(5.f, 4.f, 3.f);
|
|
|
| - AddAnimatedTransformToElementWithPlayer(child_raw->element_id(), timeline,
|
| - 1.0, TransformOperations(), scale);
|
| + AddAnimatedTransformToPlayer(child_player.get(), 1.0, TransformOperations(),
|
| + scale);
|
| child_raw->layer_tree_impl()->property_trees()->needs_rebuild = true;
|
| ExecuteCalculateDrawProperties(grand_parent_raw);
|
|
|
| @@ -7112,9 +7132,8 @@ TEST_F(LayerTreeHostCommonTest, MaximumAnimationScaleFactor) {
|
| EXPECT_EQ(1.f, GetStartingAnimationScale(child_raw));
|
| EXPECT_EQ(1.f, GetStartingAnimationScale(grand_child_raw));
|
|
|
| - AddAnimatedTransformToElementWithPlayer(grand_parent_raw->element_id(),
|
| - timeline, 1.0, TransformOperations(),
|
| - scale);
|
| + AddAnimatedTransformToPlayer(grand_parent_player.get(), 1.0,
|
| + TransformOperations(), scale);
|
| grand_parent_raw->layer_tree_impl()->property_trees()->needs_rebuild = true;
|
| ExecuteCalculateDrawProperties(grand_parent_raw);
|
|
|
| @@ -7131,8 +7150,8 @@ TEST_F(LayerTreeHostCommonTest, MaximumAnimationScaleFactor) {
|
| EXPECT_EQ(0.f, GetStartingAnimationScale(child_raw));
|
| EXPECT_EQ(0.f, GetStartingAnimationScale(grand_child_raw));
|
|
|
| - AddAnimatedTransformToElementWithPlayer(parent_raw->element_id(), timeline,
|
| - 1.0, TransformOperations(), scale);
|
| + AddAnimatedTransformToPlayer(parent_player.get(), 1.0, TransformOperations(),
|
| + scale);
|
| parent_raw->layer_tree_impl()->property_trees()->needs_rebuild = true;
|
| ExecuteCalculateDrawProperties(grand_parent_raw);
|
|
|
| @@ -7147,19 +7166,15 @@ TEST_F(LayerTreeHostCommonTest, MaximumAnimationScaleFactor) {
|
| EXPECT_EQ(0.f, GetStartingAnimationScale(child_raw));
|
| EXPECT_EQ(0.f, GetStartingAnimationScale(grand_child_raw));
|
|
|
| - AbortAnimationsOnElementWithPlayer(grand_parent_raw->element_id(), timeline,
|
| - TargetProperty::TRANSFORM);
|
| - AbortAnimationsOnElementWithPlayer(parent_raw->element_id(), timeline,
|
| - TargetProperty::TRANSFORM);
|
| - AbortAnimationsOnElementWithPlayer(child_raw->element_id(), timeline,
|
| - TargetProperty::TRANSFORM);
|
| + grand_parent_player->AbortAnimations(TargetProperty::TRANSFORM, false);
|
| + parent_player->AbortAnimations(TargetProperty::TRANSFORM, false);
|
| + child_player->AbortAnimations(TargetProperty::TRANSFORM, false);
|
|
|
| TransformOperations perspective;
|
| perspective.AppendPerspective(10.f);
|
|
|
| - AddAnimatedTransformToElementWithPlayer(child_raw->element_id(), timeline,
|
| - 1.0, TransformOperations(),
|
| - perspective);
|
| + AddAnimatedTransformToPlayer(child_player.get(), 1.0, TransformOperations(),
|
| + perspective);
|
| child_raw->layer_tree_impl()->property_trees()->needs_rebuild = true;
|
| ExecuteCalculateDrawProperties(grand_parent_raw);
|
|
|
| @@ -7183,8 +7198,8 @@ TEST_F(LayerTreeHostCommonTest, MaximumAnimationScaleFactor) {
|
| parent_raw->test_properties()->transform = scale_matrix;
|
| grand_parent_raw->layer_tree_impl()->property_trees()->needs_rebuild = true;
|
|
|
| - AddAnimatedTransformToElementWithPlayer(parent_raw->element_id(), timeline,
|
| - 1.0, TransformOperations(), scale);
|
| + AddAnimatedTransformToPlayer(parent_player.get(), 1.0, TransformOperations(),
|
| + scale);
|
| ExecuteCalculateDrawProperties(grand_parent_raw);
|
|
|
| // |grand_parent| and |parent| each have scale 2.f. |parent| has a scale
|
|
|