Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 2330283004: Fix serialization of step timing functions (Closed)

Created:
4 years, 3 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 3 months ago
Reviewers:
shans, samli
CC:
shans, darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, Eric Willigers, rjwright, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix serialization of step timing functions The CSS Transitions specification recently added a section specifying how timing functions should be serialized: https://hg.csswg.org/drafts/rev/12d32649a91f https://drafts.csswg.org/css-transitions/#serializing-a-timing-function This patch changes how step timing functions are serialized in order to bring it in line with the spec. The corresponding parsing function devtools/front_end is also updated. The removal of "step-middle" and "steps(x, middle)" as valid values is deferred until frames() is implemented (see crbug.com/646265). BUG=631875, 600248 Committed: https://crrev.com/d660b195483e9910ee6bfc3ad25df28301a35259 Cr-Commit-Position: refs/heads/master@{#418704}

Patch Set 1 #

Patch Set 2 : Update step timing function parsing in devtools #

Messages

Total messages: 22 (14 generated)
suzyh_UTC10 (ex-contributor)
4 years, 3 months ago (2016-09-13 06:44:20 UTC) #2
suzyh_UTC10 (ex-contributor)
On 2016/09/13 at 06:44:20, suzyh wrote: > NB: Updated the CL description to document the ...
4 years, 3 months ago (2016-09-13 07:01:54 UTC) #6
suzyh_UTC10 (ex-contributor)
+samli for devtools/front_end
4 years, 3 months ago (2016-09-14 04:49:44 UTC) #11
samli
devtools/front_end lgtm
4 years, 3 months ago (2016-09-14 05:37:33 UTC) #14
shans
lgtm
4 years, 3 months ago (2016-09-14 22:38:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330283004/20001
4 years, 3 months ago (2016-09-14 22:39:25 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 22:45:14 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 22:48:50 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d660b195483e9910ee6bfc3ad25df28301a35259
Cr-Commit-Position: refs/heads/master@{#418704}

Powered by Google App Engine
This is Rietveld 408576698