third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js - Issue 2330283004: Fix serialization of step timing functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

Issue 2330283004: Fix serialization of step timing functions (Closed)

Patch Set: Update step timing function parsing in devtools Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp ('k') | third_party/WebKit/Source/platform/animation/TimingFunction.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

diff --git a/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js b/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

index 71aba877044d69e0f1c201644413993fed4ef5be..0c608e10e5c26be13b71bc06ab61cdb9c7d5c3b2 100644

--- a/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

+++ b/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

@@ -762,11 +762,11 @@ WebInspector.AnimationTimeline.StepTimingFunction = function(steps, stepAtPositi

* @return {?WebInspector.AnimationTimeline.StepTimingFunction}

WebInspector.AnimationTimeline.StepTimingFunction.parse = function(text) {

- var match = text.match(/^step-(start|middle|end)$/);

- if (match)

- return new WebInspector.AnimationTimeline.StepTimingFunction(1, match[1]);

- match = text.match(/^steps$(\d+), (start|middle|end)$$/);

+ var match = text.match(/^steps$(\d+), (start|middle)$$/);

if (match)

return new WebInspector.AnimationTimeline.StepTimingFunction(parseInt(match[1], 10), match[2]);

+ match = text.match(/^steps$(\d+)$$/);

+ if (match)

+ return new WebInspector.AnimationTimeline.StepTimingFunction(parseInt(match[1], 10), "end");

return null;

}