Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

Issue 2330283004: Fix serialization of step timing functions (Closed)
Patch Set: Update step timing function parsing in devtools Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp b/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
index bdea64b6a44137e248466cc3bc6fe28886c97a98..b3e1f7ef53fc575cff833f4568f2d0b22395fc6b 100644
--- a/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
@@ -129,7 +129,7 @@ TEST_F(AnimationKeyframeEffectV8Test, SpecifiedGetters)
setV8ObjectPropertyAsNumber(scope.isolate(), timingInput, "iterationStart", 2);
setV8ObjectPropertyAsNumber(scope.isolate(), timingInput, "iterations", 10);
setV8ObjectPropertyAsString(scope.isolate(), timingInput, "direction", "reverse");
- setV8ObjectPropertyAsString(scope.isolate(), timingInput, "easing", "step-start");
+ setV8ObjectPropertyAsString(scope.isolate(), timingInput, "easing", "ease-in-out");
KeyframeEffectOptions timingInputDictionary;
TrackExceptionState exceptionState;
V8KeyframeEffectOptions::toImpl(scope.isolate(), timingInput, timingInputDictionary, exceptionState);
@@ -144,7 +144,7 @@ TEST_F(AnimationKeyframeEffectV8Test, SpecifiedGetters)
EXPECT_EQ(2, specified->iterationStart());
EXPECT_EQ(10, specified->iterations());
EXPECT_EQ("reverse", specified->direction());
- EXPECT_EQ("step-start", specified->easing());
+ EXPECT_EQ("ease-in-out", specified->easing());
}
TEST_F(AnimationKeyframeEffectV8Test, SpecifiedDurationGetter)
@@ -228,9 +228,9 @@ TEST_F(AnimationKeyframeEffectV8Test, SpecifiedSetters)
EXPECT_EQ("reverse", specified->direction());
EXPECT_EQ("linear", specified->easing());
- specified->setEasing("step-start", exceptionState);
+ specified->setEasing("ease-in-out", exceptionState);
ASSERT_FALSE(exceptionState.hadException());
- EXPECT_EQ("step-start", specified->easing());
+ EXPECT_EQ("ease-in-out", specified->easing());
}
TEST_F(AnimationKeyframeEffectV8Test, SetSpecifiedDuration)

Powered by Google App Engine
This is Rietveld 408576698