third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp - Issue 2330283004: Fix serialization of step timing functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp

Issue 2330283004: Fix serialization of step timing functions (Closed)

Patch Set: Update step timing function parsing in devtools Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing.html ('k') | third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp

diff --git a/third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp b/third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp

index 7c39615daaf12e23322f97416a93e0b94af6a96a..cc1fa760333970dbbe233954330ce59d3f86bb65 100644

--- a/third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp

+++ b/third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp

@@ -96,15 +96,15 @@ TEST_F(AnimationAnimationInputHelpersTest, ParseAnimationTimingFunction)

timingFunctionRoundTrips("ease-in", exceptionState);

timingFunctionRoundTrips("ease-out", exceptionState);

timingFunctionRoundTrips("ease-in-out", exceptionState);

- timingFunctionRoundTrips("step-start", exceptionState);

- timingFunctionRoundTrips("step-middle", exceptionState);

- timingFunctionRoundTrips("step-end", exceptionState);

- timingFunctionRoundTrips("steps(3, start)", exceptionState);

- timingFunctionRoundTrips("steps(3, middle)", exceptionState);

- timingFunctionRoundTrips("steps(3, end)", exceptionState);

timingFunctionRoundTrips("cubic-bezier(0.1, 5, 0.23, 0)", exceptionState);

- EXPECT_EQ("steps(3, end)", parseTimingFunction("steps(3)", exceptionState)->toString());

+ EXPECT_EQ("steps(1, start)", parseTimingFunction("step-start", exceptionState)->toString());

+ EXPECT_EQ("steps(1, middle)", parseTimingFunction("step-middle", exceptionState)->toString());

+ EXPECT_EQ("steps(1)", parseTimingFunction("step-end", exceptionState)->toString());

+ EXPECT_EQ("steps(3, start)", parseTimingFunction("steps(3, start)", exceptionState)->toString());

+ EXPECT_EQ("steps(3, middle)", parseTimingFunction("steps(3, middle)", exceptionState)->toString());

+ EXPECT_EQ("steps(3)", parseTimingFunction("steps(3, end)", exceptionState)->toString());

+ EXPECT_EQ("steps(3)", parseTimingFunction("steps(3)", exceptionState)->toString());

timingFunctionThrows("steps(3, nowhere)", exceptionState);

timingFunctionThrows("steps(-3, end)", exceptionState);