Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing.html

Issue 2330283004: Fix serialization of step timing functions (Closed)
Patch Set: Update step timing function parsing in devtools Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing.html
diff --git a/third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing.html b/third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing.html
index c45d554ccc2e46f8be43de79415e6433c5361c3e..f66af317411d689e0ce4f47d0b512d585895f2b9 100644
--- a/third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing.html
+++ b/third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing.html
@@ -31,18 +31,18 @@ test(function() {
assert_animate_with_easing_roundtrips('ease-in');
assert_animate_with_easing_roundtrips('ease-out');
assert_animate_with_easing_roundtrips('ease-in-out');
- assert_animate_with_easing_roundtrips('step-start');
- assert_animate_with_easing_roundtrips('step-middle');
- assert_animate_with_easing_roundtrips('step-end');
- assert_animate_with_easing_roundtrips('steps(3, start)');
- assert_animate_with_easing_roundtrips('steps(3, middle)');
- assert_animate_with_easing_roundtrips('steps(3, end)');
assert_animate_with_easing_roundtrips('cubic-bezier(0.1, 5, 0.23, 0)');
-}, 'Valid easing functions should come out the same as they went in');
+}, 'Valid linear and cubic-bezier easing functions should come out the same as they went in');
test(function() {
- assert_animate_with_easing_succeeds('steps(3)', 'steps(3, end)');
-}, 'steps easing second parameter defaults to end');
+ assert_animate_with_easing_succeeds('step-start', 'steps(1, start)');
+ assert_animate_with_easing_succeeds('step-middle', 'steps(1, middle)');
+ assert_animate_with_easing_succeeds('step-end', 'steps(1)');
+ assert_animate_with_easing_succeeds('steps(3, start)', 'steps(3, start)');
+ assert_animate_with_easing_succeeds('steps(3, middle)', 'steps(3, middle)');
+ assert_animate_with_easing_succeeds('steps(3, end)', 'steps(3)');
+ assert_animate_with_easing_succeeds('steps(3)', 'steps(3)');
+}, 'Valid step-function easings serialize as steps(<int>) or steps(<int>, start)');
test(function() {
assert_animate_with_easing_succeeds('eAse\\2d iN-ouT', 'ease-in-out');

Powered by Google App Engine
This is Rietveld 408576698