Do not show shelf or top chrome hints while in Ash immersive mode

Do not show shelf or top chrome hints while in Ash immersive mode

Introduced a new Material Design controller called IsImmersiveModeMaterial,
which controls the default behavior of ash immersive mode. By default, the
immersive mode hints on top chrome and on shelf are hidden. The hints are
showing when the flag ash-md is set to disabled.

TEST=Shelf_layout_manager_unittests, immersive_mode_controller_ash_unittests

BUG=641951, 623432
Committed: https://crrev.com/13b74d6d6843827a883181b1a8f7c5cf11d3b09d
Cr-Commit-Position: refs/heads/master@{#417461}

[yiyix, 2016-09-08 19:30:12]

Description was changed from

==========
fix tests


fix tests


initial


trial

BUG=
==========

to

==========
fix tests


fix tests


initial


trial

BUG=641951, 623432
==========

[yiyix, 2016-09-08 19:52:22]

Description was changed from

==========
fix tests


fix tests


initial


trial

BUG=641951, 623432
==========

to

==========
Do not show shelf or top chrome hints while in Ash immersive mode

Introduced a new Material Design controller called IsImmersiveModeEnabled, 
which controls the default behavior of ash immersive mode. By default, the 
immersive mode hints on top chrome and on shelf are hidden. The hints are 
showing when the flag ash-md is set to disabled.

TEST=Shelf_layout_manager_unittests, immersive_mode_controller_ash_unittests

BUG=641951, 623432
==========

[yiyix, 2016-09-08 19:54:42]

Patchset #1 (id:1) has been deleted

[yiyix, 2016-09-08 19:55:17]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 19:55:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yiyix, 2016-09-08 20:01:13]

Patchset #1 (id:20001) has been deleted

[yiyix, 2016-09-08 20:01:26]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 20:02:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yiyix, 2016-09-08 20:09:44]

yiyix@chromium.org changed reviewers:
+ jamescook@chromium.org, msw@chromium.org, tdanderson@chromium.org

[yiyix, 2016-09-08 20:09:45]

Could you please review this code change? Thank you very much

[James Cook, 2016-09-08 20:33:33]

https://codereview.chromium.org/2326703002/diff/40001/ash/common/material_des...
File ash/common/material_design/material_design_controller.h (right):

https://codereview.chromium.org/2326703002/diff/40001/ash/common/material_des...
ash/common/material_design/material_design_controller.h:46: // Returns true if
Material Design features are enable for Chrome OS immersive
nit: enable -> enabled

https://codereview.chromium.org/2326703002/diff/40001/ash/common/material_des...
ash/common/material_design/material_design_controller.h:48: static bool
IsImmersiveModeEnabled();
This should be IsImmersiveModeMaterial(). Right now it sounds like whether or
not the immersive-mode feature itself is enabled.

https://codereview.chromium.org/2326703002/diff/40001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2326703002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager_unittest.cc:592: // Switch from visible to
invisible autodhide.
autohide

[commit-bot: I haz the power, 2016-09-08 20:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 20:53:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tdanderson, 2016-09-08 21:19:14]

lgtm with James's comments addressed (plus my one comment below).

https://codereview.chromium.org/2326703002/diff/40001/ash/common/material_des...
File ash/common/material_design/material_design_controller.cc (right):

https://codereview.chromium.org/2326703002/diff/40001/ash/common/material_des...
ash/common/material_design/material_design_controller.cc:72: return
IsMaterialExperimental() || IsMaterialNormal();
Just call IsMaterial() instead.

[yiyix, 2016-09-08 22:25:24]

Patchset #2 (id:60001) has been deleted

[yiyix, 2016-09-08 22:34:37]

Patchset #2 (id:80001) has been deleted

[yiyix, 2016-09-08 22:36:19]

@jamescook, tdanderson and msw, could you please check this change again?

https://codereview.chromium.org/2326703002/diff/40001/ash/common/material_des...
File ash/common/material_design/material_design_controller.cc (right):

https://codereview.chromium.org/2326703002/diff/40001/ash/common/material_des...
ash/common/material_design/material_design_controller.cc:72: return
IsMaterialExperimental() || IsMaterialNormal();
On 2016/09/08 21:19:14, tdanderson wrote:
> Just call IsMaterial() instead.

Done.

https://codereview.chromium.org/2326703002/diff/40001/ash/common/material_des...
File ash/common/material_design/material_design_controller.h (right):

https://codereview.chromium.org/2326703002/diff/40001/ash/common/material_des...
ash/common/material_design/material_design_controller.h:46: // Returns true if
Material Design features are enable for Chrome OS immersive
On 2016/09/08 20:33:33, James Cook wrote:
> nit: enable -> enabled

Done.

https://codereview.chromium.org/2326703002/diff/40001/ash/common/material_des...
ash/common/material_design/material_design_controller.h:48: static bool
IsImmersiveModeEnabled();
On 2016/09/08 20:33:33, James Cook wrote:
> This should be IsImmersiveModeMaterial(). Right now it sounds like whether or
> not the immersive-mode feature itself is enabled.

You are right, this method is poorly named. This name is also used to enable
immersive mode in browser. I took name from the bug description. I wasn't
thinking.

https://codereview.chromium.org/2326703002/diff/40001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2326703002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager_unittest.cc:592: // Switch from visible to
invisible autodhide.
On 2016/09/08 20:33:33, James Cook wrote:
> autohide

typo on both line 574 and 591. fixed both

[yiyix, 2016-09-08 22:36:25]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[yiyix, 2016-09-08 22:36:44]

Description was changed from

==========
Do not show shelf or top chrome hints while in Ash immersive mode

Introduced a new Material Design controller called IsImmersiveModeEnabled, 
which controls the default behavior of ash immersive mode. By default, the 
immersive mode hints on top chrome and on shelf are hidden. The hints are 
showing when the flag ash-md is set to disabled.

TEST=Shelf_layout_manager_unittests, immersive_mode_controller_ash_unittests

BUG=641951, 623432
==========

to

==========
Do not show shelf or top chrome hints while in Ash immersive mode

Introduced a new Material Design controller called IsImmersiveModeMaterial, 
which controls the default behavior of ash immersive mode. By default, the 
immersive mode hints on top chrome and on shelf are hidden. The hints are 
showing when the flag ash-md is set to disabled.

TEST=Shelf_layout_manager_unittests, immersive_mode_controller_ash_unittests

BUG=641951, 623432
==========

[commit-bot: I haz the power, 2016-09-08 22:37:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-09-08 22:39:47]

LGTM

[msw, 2016-09-08 22:45:13]

lgtm

[commit-bot: I haz the power, 2016-09-08 23:19:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:19:42]

Dry run: This issue passed the CQ dry run.

[yiyix, 2016-09-09 00:41:09]

The CQ bit was checked by yiyix@chromium.org

[yiyix, 2016-09-09 00:41:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2326703002/#ps100001
(title: "address comments")

[commit-bot: I haz the power, 2016-09-09 00:41:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 00:49:32]

Description was changed from

==========
Do not show shelf or top chrome hints while in Ash immersive mode

Introduced a new Material Design controller called IsImmersiveModeMaterial, 
which controls the default behavior of ash immersive mode. By default, the 
immersive mode hints on top chrome and on shelf are hidden. The hints are 
showing when the flag ash-md is set to disabled.

TEST=Shelf_layout_manager_unittests, immersive_mode_controller_ash_unittests

BUG=641951, 623432
==========

to

==========
Do not show shelf or top chrome hints while in Ash immersive mode

Introduced a new Material Design controller called IsImmersiveModeMaterial, 
which controls the default behavior of ash immersive mode. By default, the 
immersive mode hints on top chrome and on shelf are hidden. The hints are 
showing when the flag ash-md is set to disabled.

TEST=Shelf_layout_manager_unittests, immersive_mode_controller_ash_unittests

BUG=641951, 623432
==========

[commit-bot: I haz the power, 2016-09-09 00:49:33]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-09-09 00:53:22]

Description was changed from

==========
Do not show shelf or top chrome hints while in Ash immersive mode

Introduced a new Material Design controller called IsImmersiveModeMaterial, 
which controls the default behavior of ash immersive mode. By default, the 
immersive mode hints on top chrome and on shelf are hidden. The hints are 
showing when the flag ash-md is set to disabled.

TEST=Shelf_layout_manager_unittests, immersive_mode_controller_ash_unittests

BUG=641951, 623432
==========

to

==========
Do not show shelf or top chrome hints while in Ash immersive mode

Introduced a new Material Design controller called IsImmersiveModeMaterial,
which controls the default behavior of ash immersive mode. By default, the
immersive mode hints on top chrome and on shelf are hidden. The hints are
showing when the flag ash-md is set to disabled.

TEST=Shelf_layout_manager_unittests, immersive_mode_controller_ash_unittests

BUG=641951, 623432

Committed: https://crrev.com/13b74d6d6843827a883181b1a8f7c5cf11d3b09d
Cr-Commit-Position: refs/heads/master@{#417461}
==========

[commit-bot: I haz the power, 2016-09-09 00:53:24]

Patchset 2 (id:??) landed as
https://crrev.com/13b74d6d6843827a883181b1a8f7c5cf11d3b09d
Cr-Commit-Position: refs/heads/master@{#417461}

[oshima, 2016-09-09 06:43:49]

Description was changed from

==========
Do not show shelf or top chrome hints while in Ash immersive mode

Introduced a new Material Design controller called IsImmersiveModeMaterial,
which controls the default behavior of ash immersive mode. By default, the
immersive mode hints on top chrome and on shelf are hidden. The hints are
showing when the flag ash-md is set to disabled.

TEST=Shelf_layout_manager_unittests, immersive_mode_controller_ash_unittests

BUG=641951, 623432

Committed: https://crrev.com/13b74d6d6843827a883181b1a8f7c5cf11d3b09d
Cr-Commit-Position: refs/heads/master@{#417461}
==========

to

==========
Do not show shelf or top chrome hints while in Ash immersive mode

Introduced a new Material Design controller called IsImmersiveModeMaterial,
which controls the default behavior of ash immersive mode. By default, the
immersive mode hints on top chrome and on shelf are hidden. The hints are
showing when the flag ash-md is set to disabled.

TEST=Shelf_layout_manager_unittests, immersive_mode_controller_ash_unittests

BUG=641951, 623432

Committed: https://crrev.com/13b74d6d6843827a883181b1a8f7c5cf11d3b09d
Cr-Commit-Position: refs/heads/master@{#417461}
==========