chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc - Issue 2326703002: Do not show shelf or top chrome hints while in Ash immersive mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

Issue 2326703002: Do not show shelf or top chrome hints while in Ash immersive mode (Closed)

Patch Set: address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

index ca1e9c52ac0cc34effa605ec9ea6acc1b5548a77..0a4c801d0c4b88eab8d75f84d4ed30f3f6faaff1 100644

--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

@@ -202,7 +202,7 @@ void ImmersiveModeControllerAsh::LayoutBrowserRootView() {

// remove all code related to immersive mode hints (here, in TabStrip and

// BrowserNonClientFrameViewAsh::OnPaint()). See crbug.com/614453.

bool ImmersiveModeControllerAsh::UpdateTabIndicators() {

- if (ash::MaterialDesignController::IsShelfMaterial())

+ if (ash::MaterialDesignController::IsImmersiveModeMaterial())

return false;

bool has_tabstrip = browser_view_->IsBrowserTypeNormal();