Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8667)

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

Issue 2326703002: Do not show shelf or top chrome hints while in Ash immersive mode (Closed)
Patch Set: address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
index 0d229a21a3425d8f727cbbdcb344e29b83247400..1612c6e5272b97b6187a9979e5a465749aa259d2 100644
--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
@@ -135,7 +135,7 @@ TEST_F(ImmersiveModeControllerAshTest, Layout) {
// For MD, the browser's top chrome is completely hidden in immersive
// fullscreen mode.
bool is_using_material_design =
- ash::MaterialDesignController::IsShelfMaterial();
+ ash::MaterialDesignController::IsImmersiveModeMaterial();
if (is_using_material_design) {
EXPECT_FALSE(tabstrip->visible());
} else {
@@ -262,13 +262,13 @@ TEST_F(ImmersiveModeControllerAshTest, TabAndBrowserFullscreen) {
ToggleFullscreen();
ASSERT_TRUE(controller()->IsEnabled());
EXPECT_EQ(ash::SHELF_AUTO_HIDE, shelf->visibility_state());
- if (!ash::MaterialDesignController::IsShelfMaterial())
+ if (!ash::MaterialDesignController::IsImmersiveModeMaterial())
EXPECT_FALSE(controller()->ShouldHideTabIndicators());
SetTabFullscreen(true);
ASSERT_TRUE(controller()->IsEnabled());
EXPECT_EQ(ash::SHELF_HIDDEN, shelf->visibility_state());
- if (!ash::MaterialDesignController::IsShelfMaterial())
+ if (!ash::MaterialDesignController::IsImmersiveModeMaterial())
EXPECT_TRUE(controller()->ShouldHideTabIndicators());
// 2) Test that exiting tab fullscreen shows the tab indicators and autohides
@@ -276,7 +276,7 @@ TEST_F(ImmersiveModeControllerAshTest, TabAndBrowserFullscreen) {
SetTabFullscreen(false);
ASSERT_TRUE(controller()->IsEnabled());
EXPECT_EQ(ash::SHELF_AUTO_HIDE, shelf->visibility_state());
- if (!ash::MaterialDesignController::IsShelfMaterial())
+ if (!ash::MaterialDesignController::IsImmersiveModeMaterial())
EXPECT_FALSE(controller()->ShouldHideTabIndicators());
// 3) Test that exiting tab fullscreen and immersive fullscreen
@@ -286,7 +286,7 @@ TEST_F(ImmersiveModeControllerAshTest, TabAndBrowserFullscreen) {
ToggleFullscreen();
ASSERT_FALSE(controller()->IsEnabled());
EXPECT_EQ(ash::SHELF_VISIBLE, shelf->visibility_state());
- if (!ash::MaterialDesignController::IsShelfMaterial())
+ if (!ash::MaterialDesignController::IsImmersiveModeMaterial())
EXPECT_TRUE(controller()->ShouldHideTabIndicators());
}
« no previous file with comments | « chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698