Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Issue 2323573002: Revert of Allow canvases to be GPU-accelerated in Workers (Closed)

Created:
4 years, 3 months ago by lushnikov
Modified:
4 years, 3 months ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Rik, f(malita), blink-reviews, piman+watch_chromium.org, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis, xlai (Olivia), xidachen, Stephen White
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow canvases to be GPU-accelerated in Workers (patchset #5 id:80001 of https://codereview.chromium.org/2300633004/ ) Reason for revert: This makes the following tests fail on Linux MSAN bot: virtual/gpu/fast/canvas/canvas-createImageBitmap-invalid-blob-in-workers.html virtual/display_list_2d_canvas/fast/canvas/canvas-createImageBitmap-invalid-blob-in-workers.html Build link: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/12091 Original issue's description: > Allow canvases to be GPU-accelerated in Workers > > This change sets up a per-thread shared GPU context that is managed by > a thread-specific singleton SharedGpuContext. This means that all 2D > contexts on a given worker will use the same context, which avoids > having to rely on mailboxes all the time. Also this CL makes deep changes > to AcceleratedStaticBitmapImage in order to support the use of > the current thread's shared context, and it handles transfers > between threads in order to support the transferrable behavior of > ImageBitmap objects. > > BUG=593514 > > Committed: https://crrev.com/83ac5ff37da4ea1c6d052649ccea46dd4bd453d6 > Cr-Commit-Position: refs/heads/master@{#416929} TBR=kbr@chromium.org,haraken@chromium.org,junov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=593514 Committed: https://crrev.com/5235c5b0662c2553b0c10ebece983c04d00ebed6 Cr-Commit-Position: refs/heads/master@{#417127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -358 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +7 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-ImageBitmap-worker-to-worker.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-ImageBitmap-worker-to-worker-1.js View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-ImageBitmap-worker-to-worker-2.js View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h View 3 chunks +14 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp View 6 chunks +34 lines, -115 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp View 3 chunks +7 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 2 chunks +3 lines, -1 line 0 comments Download
D third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.h View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp View 1 chunk +0 lines, -103 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
lushnikov
Created Revert of Allow canvases to be GPU-accelerated in Workers
4 years, 3 months ago (2016-09-08 00:13:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323573002/1
4 years, 3 months ago (2016-09-08 00:13:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 00:16:29 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5235c5b0662c2553b0c10ebece983c04d00ebed6 Cr-Commit-Position: refs/heads/master@{#417127}
4 years, 3 months ago (2016-09-08 00:20:02 UTC) #7
Justin Novosad
4 years, 3 months ago (2016-09-08 14:19:44 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2321063002/ by junov@chromium.org.

The reason for reverting is: The failure that was the reason for the original
revert is still happening, so this change was not the cause.  Reverting the
revert....

Powered by Google App Engine
This is Rietveld 408576698