Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2321223003: Revert of Move collectGarbage* methods to ThreadState (Closed)

Created:
4 years, 3 months ago by dmurph
Modified:
4 years, 3 months ago
CC:
chromium-reviews, shans, dshwang, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+watch, rwlbuis, Mads Ager (chromium), blink-reviews-css, blink-reviews-html_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, blink-reviews, Eric Willigers, rjwright, blink-reviews-style_chromium.org, sof, darktears, jsbell+idb_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-animation_chromium.org, loading-reviews+parser_chromium.org, cmumford, oilpan-reviews, kouhei+heap_chromium.org, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move collectGarbage* methods to ThreadState (patchset #3 id:40001 of https://codereview.chromium.org/2307003002/ ) Reason for revert: Causing weird MSAN and other issues: BUG=645227, 645253 Reverting. Original issue's description: > Move collectGarbage* methods to ThreadState > > Move collectGarbage* methods to ThreadState to indicate that these run GC for the current thread heap. > > BUG= > > Committed: https://crrev.com/89d83a49a6c126d91e25e2d3520cb398e8e1f7d5 > Cr-Commit-Position: refs/heads/master@{#417269} TBR=oilpan-reviews@chromium.org,haraken@chromium.org,keishi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/95c96ebccbe105910c18e9c452a24d4c39b533c6 Cr-Commit-Position: refs/heads/master@{#417413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -322 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationStackTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/DocumentTimelineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStatisticsCollectorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContextTaskTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumerForDataConsumerHandleTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/LifecycleContextTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 2 chunks +170 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/RunAllTests.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 11 chunks +10 lines, -224 lines 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLFuzzer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAuraTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/RunAllTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebHeap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
dmurph
Created Revert of Move collectGarbage* methods to ThreadState
4 years, 3 months ago (2016-09-08 22:05:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321223003/1
4 years, 3 months ago (2016-09-08 22:05:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 22:07:21 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/95c96ebccbe105910c18e9c452a24d4c39b533c6 Cr-Commit-Position: refs/heads/master@{#417413}
4 years, 3 months ago (2016-09-08 22:10:15 UTC) #8
haraken
4 years, 3 months ago (2016-09-08 23:40:19 UTC) #9
Message was sent while issue was closed. 
LGTM, thanks for the revert!

Powered by Google App Engine
This is Rietveld 408576698