third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp - Issue 2321223003: Revert of Move collectGarbage* methods to ThreadState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

Issue 2321223003: Revert of Move collectGarbage* methods to ThreadState (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp b/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

index 19fa1e3ffc5e36e3ba0e8c43fa61c4d144a58408..f969ce6aa5f7633b76e955fd8f068dc6362a2286 100644

--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

@@ -455,7 +455,7 @@

Persistent<BodyStreamBuffer> buffer = new BodyStreamBuffer(scope.getScriptState(), createFetchDataConsumerHandleFromWebHandle(std::move(handle)));

buffer->startLoading(FetchDataLoader::createLoaderAsString(), client);

- ThreadState::current()-> collectAllGarbage();

+ ThreadHeap::collectAllGarbage();

checkpoint.Call(1);

testing::runPendingTasks();

checkpoint.Call(2);