third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp - Issue 2321223003: Revert of Move collectGarbage* methods to ThreadState

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp

Issue 2321223003: Revert of Move collectGarbage* methods to ThreadState (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp ('k') | third_party/WebKit/Source/core/animation/DocumentTimelineTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2013, Google Inc. All rights reserved.	2 * Copyright (c) 2013, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 997 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1008 EXPECT_FALSE(animation1->hasActiveAnimationsOnCompositor());	1008 EXPECT_FALSE(animation1->hasActiveAnimationsOnCompositor());

1009 EXPECT_FALSE(animation2->hasActiveAnimationsOnCompositor());	1009 EXPECT_FALSE(animation2->hasActiveAnimationsOnCompositor());

1010	1010

1011 simulateFrame(0);	1011 simulateFrame(0);

1012 EXPECT_EQ(2U, element->elementAnimations()->animations().size());	1012 EXPECT_EQ(2U, element->elementAnimations()->animations().size());

1013 simulateFrame(1.);	1013 simulateFrame(1.);

1014	1014

1015 element->setLayoutObject(nullptr);	1015 element->setLayoutObject(nullptr);

1016 LayoutObjectProxy::dispose(layoutObject);	1016 LayoutObjectProxy::dispose(layoutObject);

1017	1017

1018 ThreadState::current()-> collectAllGarbage();	1018 ThreadHeap::collectAllGarbage();

1019 EXPECT_TRUE(element->elementAnimations()->animations().isEmpty());	1019 EXPECT_TRUE(element->elementAnimations()->animations().isEmpty());

1020 }	1020 }

1021	1021

1022 } // namespace blink	1022 } // namespace blink

OLD	NEW