third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp - Issue 2321223003: Revert of Move collectGarbage* methods to ThreadState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

Issue 2321223003: Revert of Move collectGarbage* methods to ThreadState (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp b/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

index 2b932381d0e3aba65cdb7016ea67890e8c0b0a02..3ab28ef9531f4a7b2e780c1a2d98b80f403f8d9f 100644

--- a/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

+++ b/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

@@ -437,7 +437,7 @@

m_scriptRunner.release();

- ThreadState::current()-> collectAllGarbage();

+ ThreadHeap::collectAllGarbage();

// m_scriptRunner is gone. We need to make sure that ScriptRunner::Task do not access dead object.

EXPECT_CALL(*scriptLoader1, execute()).Times(0);