Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp

Issue 2321223003: Revert of Move collectGarbage* methods to ThreadState (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
index 8bd2ab07ea2a2bbf8142daab88b0d764c5f7bf67..ce3a4786f4213e583275f9834c483b4fd8f6cf97 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
@@ -75,13 +75,13 @@
PersistentHeapHashSet<WeakMember<IDBTransaction>> set;
set.add(transaction);
- ThreadState::current()-> collectAllGarbage();
+ ThreadHeap::collectAllGarbage();
EXPECT_EQ(1u, set.size());
Persistent<IDBRequest> request = IDBRequest::create(scope.getScriptState(), IDBAny::createUndefined(), transaction.get());
deactivateNewTransactions(scope.isolate());
- ThreadState::current()-> collectAllGarbage();
+ ThreadHeap::collectAllGarbage();
EXPECT_EQ(1u, set.size());
// This will generate an abort() call to the back end which is dropped by the fake proxy,
@@ -90,7 +90,7 @@
transaction->onAbort(DOMException::create(AbortError, "Aborted"));
transaction.clear();
- ThreadState::current()-> collectAllGarbage();
+ ThreadHeap::collectAllGarbage();
EXPECT_EQ(0u, set.size());
}
@@ -111,17 +111,17 @@
PersistentHeapHashSet<WeakMember<IDBTransaction>> set;
set.add(transaction);
- ThreadState::current()-> collectAllGarbage();
+ ThreadHeap::collectAllGarbage();
EXPECT_EQ(1u, set.size());
deactivateNewTransactions(scope.isolate());
- ThreadState::current()-> collectAllGarbage();
+ ThreadHeap::collectAllGarbage();
EXPECT_EQ(1u, set.size());
transaction.clear();
- ThreadState::current()-> collectAllGarbage();
+ ThreadHeap::collectAllGarbage();
EXPECT_EQ(1u, set.size());
// Stop the context, so events don't get queued (which would keep the transaction alive).
@@ -132,7 +132,7 @@
db->onAbort(transactionId, DOMException::create(AbortError, "Aborted"));
// onAbort() should have cleared the transaction's reference to the database.
- ThreadState::current()-> collectAllGarbage();
+ ThreadHeap::collectAllGarbage();
EXPECT_EQ(0u, set.size());
}

Powered by Google App Engine
This is Rietveld 408576698