Move onBindViewHolder from NewTabPageViewHolder to NewTabPageItem.

Move onBindViewHolder from NewTabPageViewHolder to NewTabPageItem.

This moves NewTabPageItem further away from being a generic base class for holding the data shown in the RecyclerView, and will allow pushing the responsibility to update the view into the merged item/group interface.

BUG=616090
Committed: https://crrev.com/42d87c5d7b85ba9d6df6bcaa8b1f7830e5e8430f
Cr-Commit-Position: refs/heads/master@{#417291}

[Bernhard Bauer, 2016-09-07 11:19:04]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 11:19:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 12:48:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 12:48:23]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Bernhard Bauer, 2016-09-08 10:23:56]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 10:24:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 11:11:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 11:11:16]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-09-08 11:29:59]

bauerb@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Bernhard Bauer, 2016-09-08 11:30:00]

Please review. Thanks!

[Michael van Ouwerkerk, 2016-09-08 13:11:44]

Description was changed from

==========
Move onBindViewHolder() to NewTabPageItem.

This moves NewTabPageItem further away from being a generic base class for
holding the data shown in the RecyclerView, and will allow pushing the
responsibility to update the view into the merged item/group interface.

BUG=616090
==========

to

==========
Move onBindViewHolder from NewTabPageViewHolder to NewTabPageItem.

This moves NewTabPageItem further away from being a generic base class for
holding the data shown in the RecyclerView, and will allow pushing the
responsibility to update the view into the merged item/group interface.

BUG=616090
==========

[Michael van Ouwerkerk, 2016-09-08 13:26:41]

lgtm

https://codereview.chromium.org/2320573002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java
(right):

https://codereview.chromium.org/2320573002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java:83:
* Called by the NTP cards adapter to update the given {@link
NewTabPageViewHolder} with data
"Called by {@link NewTabPageAdapter}"? Or simply: "Updates the given {@link
NewTabPageViewHolder} with data from this item."

[Bernhard Bauer, 2016-09-08 13:42:47]

https://codereview.chromium.org/2320573002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java
(right):

https://codereview.chromium.org/2320573002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java:83:
* Called by the NTP cards adapter to update the given {@link
NewTabPageViewHolder} with data
On 2016/09/08 13:26:41, Michael van Ouwerkerk wrote:
> "Called by {@link NewTabPageAdapter}"? Or simply: "Updates the given {@link
> NewTabPageViewHolder} with data from this item."

Sounds good, thanks!

[Bernhard Bauer, 2016-09-08 13:42:51]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2016-09-08 13:42:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/2320573002/#ps40001
(title: "review")

[commit-bot: I haz the power, 2016-09-08 13:43:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 14:43:46]

Description was changed from

==========
Move onBindViewHolder from NewTabPageViewHolder to NewTabPageItem.

This moves NewTabPageItem further away from being a generic base class for
holding the data shown in the RecyclerView, and will allow pushing the
responsibility to update the view into the merged item/group interface.

BUG=616090
==========

to

==========
Move onBindViewHolder from NewTabPageViewHolder to NewTabPageItem.

This moves NewTabPageItem further away from being a generic base class for
holding the data shown in the RecyclerView, and will allow pushing the
responsibility to update the view into the merged item/group interface.

BUG=616090
==========

[commit-bot: I haz the power, 2016-09-08 14:43:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-08 14:45:00]

Description was changed from

==========
Move onBindViewHolder from NewTabPageViewHolder to NewTabPageItem.

This moves NewTabPageItem further away from being a generic base class for
holding the data shown in the RecyclerView, and will allow pushing the
responsibility to update the view into the merged item/group interface.

BUG=616090
==========

to

==========
Move onBindViewHolder from NewTabPageViewHolder to NewTabPageItem.

This moves NewTabPageItem further away from being a generic base class for
holding the data shown in the RecyclerView, and will allow pushing the
responsibility to update the view into the merged item/group interface.

BUG=616090

Committed: https://crrev.com/42d87c5d7b85ba9d6df6bcaa8b1f7830e5e8430f
Cr-Commit-Position: refs/heads/master@{#417291}
==========

[commit-bot: I haz the power, 2016-09-08 14:45:01]

Patchset 3 (id:??) landed as
https://crrev.com/42d87c5d7b85ba9d6df6bcaa8b1f7830e5e8430f
Cr-Commit-Position: refs/heads/master@{#417291}