Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2747)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java

Issue 2320573002: Move onBindViewHolder from NewTabPageViewHolder to NewTabPageItem. (Closed)
Patch Set: review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java
index 574b286e582135c346f562f6245e28695b47cfa9..f78cce57a4f0c105ffb988b164ee7e95fcd31b20 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java
@@ -10,7 +10,6 @@ import android.widget.TextView;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ntp.UiConfig;
import org.chromium.chrome.browser.ntp.cards.MarginResizer;
-import org.chromium.chrome.browser.ntp.cards.NewTabPageItem;
import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;
import org.chromium.chrome.browser.ntp.cards.NewTabPageViewHolder;
import org.chromium.chrome.browser.util.MathUtils;
@@ -22,8 +21,6 @@ public class SectionHeaderViewHolder extends NewTabPageViewHolder {
private static final double SCROLL_HEADER_HEIGHT_PERCENTAGE = 0.7;
private final int mMaxSnippetHeaderHeight;
- private final int mMaxPeekPadding;
- private final NewTabPageRecyclerView mRecyclerView;
private SectionHeader mHeaderListItem;
@@ -32,17 +29,11 @@ public class SectionHeaderViewHolder extends NewTabPageViewHolder {
.inflate(R.layout.new_tab_page_snippets_header, recyclerView, false));
mMaxSnippetHeaderHeight = itemView.getResources().getDimensionPixelSize(
R.dimen.snippets_article_header_height);
-
- mMaxPeekPadding = itemView.getResources().getDimensionPixelSize(
- R.dimen.snippets_padding_and_peeking_card_height);
-
- mRecyclerView = recyclerView;
MarginResizer.createWithViewAdapter(itemView, config);
}
- @Override
- public void onBindViewHolder(NewTabPageItem header) {
- mHeaderListItem = (SectionHeader) header;
+ public void onBindViewHolder(SectionHeader header) {
+ mHeaderListItem = header;
((TextView) itemView).setText(mHeaderListItem.getHeaderText());
updateDisplay(0, false);
}

Powered by Google App Engine
This is Rietveld 408576698