Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4415)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java

Issue 2320573002: Move onBindViewHolder from NewTabPageViewHolder to NewTabPageItem. (Closed)
Patch Set: review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java
index fa9ce9aa34f405914c33b6da253be7b21fba22a7..e23fa5c139ba496fdbcf739fe5ccf025d0977ad3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java
@@ -47,22 +47,19 @@ public abstract class StatusItem implements NewTabPageItem {
mActionView = (Button) itemView.findViewById(R.id.status_action_button);
}
- @Override
- public void onBindViewHolder(NewTabPageItem item) {
- assert item instanceof StatusItem;
- super.onBindViewHolder(item);
+ public void onBindViewHolder(final StatusItem item) {
+ super.onBindViewHolder();
- final StatusItem listItem = (StatusItem) item;
- mTitleView.setText(listItem.mHeaderStringId);
- mBodyView.setText(listItem.mDescriptionStringId);
+ mTitleView.setText(item.mHeaderStringId);
+ mBodyView.setText(item.mDescriptionStringId);
- if (listItem.hasAction()) {
- mActionView.setText(listItem.mActionStringId);
+ if (item.hasAction()) {
+ mActionView.setText(item.mActionStringId);
mActionView.setOnClickListener(new OnClickListener() {
@Override
public void onClick(View v) {
- listItem.performAction(v.getContext());
+ item.performAction(v.getContext());
}
});
mActionView.setVisibility(View.VISIBLE);
@@ -188,4 +185,10 @@ public abstract class StatusItem implements NewTabPageItem {
public int getType() {
return NewTabPageItem.VIEW_TYPE_STATUS;
}
+
+ @Override
+ public void onBindViewHolder(NewTabPageViewHolder holder) {
+ assert holder instanceof ViewHolder;
+ ((ViewHolder) holder).onBindViewHolder(this);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698