Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2881)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

Issue 2320573002: Move onBindViewHolder from NewTabPageViewHolder to NewTabPageItem. (Closed)
Patch Set: review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
index 5dc61ec4dc16a4208dc37b3e080221a2517a5cea..2cc6c9fba967c439fe5dfb729fbeeed8a065c668 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
@@ -4,6 +4,7 @@
package org.chromium.chrome.browser.ntp.cards;
+import android.support.annotation.CallSuper;
import android.support.annotation.DrawableRes;
import android.support.v4.view.animation.FastOutSlowInInterpolator;
import android.support.v7.widget.RecyclerView;
@@ -113,12 +114,10 @@ public class CardViewHolder extends NewTabPageViewHolder {
/**
* Called when the NTP cards adapter is requested to update the currently visible ViewHolder
- * with data. {@link CardViewHolder}'s implementation must be called by subclasses.
- *
- * @param item The NewTabPageListItem object that holds the data for this ViewHolder
+ * with data.
*/
- @Override
- public void onBindViewHolder(NewTabPageItem item) {
+ @CallSuper
+ protected void onBindViewHolder() {
// Reset the peek status to avoid recycled view holders to be peeking at the wrong moment.
if (getAdapterPosition() != mRecyclerView.getNewTabPageAdapter().getFirstCardPosition()) {
// Not the first card, we can't peek anyway.

Powered by Google App Engine
This is Rietveld 408576698